Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609037

[PATCH 4/7] usb: dwc3: exynos: change goto labels in this file to meaningful names

Show all headers | View raw

Change goto labels in this file to meaningful names

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 98f74ff..11f31f4 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -58,12 +58,12 @@ static int dwc3_exynos_register_phys(struct dwc3_exynos *exynos)
 
 	ret = platform_device_add_data(exynos->usb2_phy, &pdata, sizeof(pdata));
 	if (ret)
-		goto err1;
+		goto usb2_phy_device_put;
 
 	pdev = platform_device_alloc("usb_phy_generic", PLATFORM_DEVID_AUTO);
 	if (!pdev) {
 		ret = -ENOMEM;
-		goto err1;
+		goto usb2_phy_device_put;
 	}
 
 	exynos->usb3_phy = pdev;
@@ -71,25 +71,25 @@ static int dwc3_exynos_register_phys(struct dwc3_exynos *exynos)
 
 	ret = platform_device_add_data(exynos->usb3_phy, &pdata, sizeof(pdata));
 	if (ret)
-		goto err2;
+		goto usb3_phy_device_put;
 
 	ret = platform_device_add(exynos->usb2_phy);
 	if (ret)
-		goto err2;
+		goto usb3_phy_device_put;
 
 	ret = platform_device_add(exynos->usb3_phy);
 	if (ret)
-		goto err3;
+		goto usb2_phy_device_del;
 
 	return 0;
 
-err3:
+usb2_phy_device_del:
 	platform_device_del(exynos->usb2_phy);
 
-err2:
+usb3_phy_device_put:
 	platform_device_put(exynos->usb3_phy);
 
-err1:
+usb2_phy_device_put:
 	platform_device_put(exynos->usb2_phy);
 
 	return ret;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 7/7] usb: dwc3: host: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
    Re: [PATCH 2/7] usb: dwc3: dwc3-omap: fix dwc3_omap_probe() do put_sync when get_sync works Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
  [PATCH 3/7] usb: dwc3: core: change goto labels to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 6/7] usb: dwc3: gadget: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 4/7] usb: dwc3: exynos: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  [PATCH 5/7] usb: dwc3: omap: change goto labels in this file to meaningful names Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-25 01:10 +0100
  Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Felipe Balbi <balbi@kernel.org> - 2017-03-25 09:00 +0100
    Re: [PATCH 0/7] dwc3 - bug fixes and use meaningful goto labels Shuah Khan <shuahkh@osg.samsung.com> - 2017-03-27 15:50 +0200

csiph-web