Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1608879
| From | tip-bot for Taeung Song <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:perf/core] perf annotate: More exactly grep -v of the objdump command |
| Date | 2017-03-24 20:00 +0100 |
| Message-ID | <toCBj-5D8-13@gated-at.bofh.it> (permalink) |
| References | <tmVI5-6BY-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Gitweb: http://git.kernel.org/tip/e7cb9de211ebb2924d87fdeb77e50d74c2e673d1
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Mon, 20 Mar 2017 11:56:57 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 21 Mar 2017 15:42:25 -0300
perf annotate: More exactly grep -v of the objdump command
The 'grep -v "filename"' applied to the objdump command output cause a
side effect eliminating filename:linenr of output of 'objdump -l' if the
object file name and source file name are the same, fix it.
E.g. the output of the following objdump command in symbol__disassemble():
$ objdump -l -d -S -C /home/taeung/hello --start-address=...
/home/taeung/hello: file format elf64-x86-64
Disassembly of section .text:
0000000000400526 <main>:
main():
/home/taeung/hello.c:4
void main()
{
400526: 55 push %rbp
400527: 48 89 e5 mov %rsp,%rbp
/home/taeung/hello.c:5
...
But it uses grep -v "filename" e.g. "/home/taeung/hello" in the objdump
command to remove the first line containing file name and file format
("/home/taeung/hello: file format elf64-x86-64"):
Before:
$ objdump -l -d -S -C /home/taeung/hello | grep /home/taeung/hello
But this causes a side effect, removing filename:linenr too, because the
object file and source file have the same name e.g. "/home/taueng/hello",
"/home/taeung/hello.c"
So more do a better match by using grep -v as below to correctly remove
that first line:
"/home/taeung/hello: file format elf64-x86-64"
After:
$ objdump -l -d -S -C /home/taeung/hello | grep /home/taeung/hello:
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1489978617-31396-5-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 273f21f..4d325cd 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1435,7 +1435,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na
snprintf(command, sizeof(command),
"%s %s%s --start-address=0x%016" PRIx64
" --stop-address=0x%016" PRIx64
- " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand",
+ " -l -d %s %s -C %s 2>/dev/null|grep -v %s:|expand",
objdump_path ? objdump_path : "objdump",
disassembler_style ? "-M " : "",
disassembler_style ? disassembler_style : "",
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] perf annotate: Bugfixes Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
[PATCH 3/4] perf annotate: Fix missing setting nr samples on source_line Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
[PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:50 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 17:30 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 08:40 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <taeung.dev@gmail.com> - 2017-03-21 17:30 +0100
[tip:perf/core] perf annotate: More exactly grep -v of the objdump command tip-bot for Taeung Song <tipbot@zytor.com> - 2017-03-24 20:00 +0100
[PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-20 19:20 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:20 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:30 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:20 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:40 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 15:50 +0100
Re: [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 13:10 +0100
csiph-web