Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605883

Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command
Date 2017-03-21 19:40 +0100
Message-ID <tnwRj-779-7@gated-at.bofh.it> (permalink)
References <tmVI5-6BY-3@gated-at.bofh.it> <tmVI5-6BY-9@gated-at.bofh.it> <tntgJ-4Dp-7@gated-at.bofh.it> <tnuPw-5O6-9@gated-at.bofh.it> <tnwRj-779-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Em Tue, Mar 21, 2017 at 03:29:50PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Mar 22, 2017 at 01:19:49AM +0900, Taeung Song escreveu:
> > On 03/21/2017 11:37 PM, Arnaldo Carvalho de Melo wrote:
> > > > +++ b/tools/perf/util/annotate.c
> > > > @@ -1443,7 +1443,7 @@ int symbol__disassemble(struct symbol *sym, struct map *map, const char *arch_na
> > > >  	snprintf(command, sizeof(command),
> > > >  		 "%s %s%s --start-address=0x%016" PRIx64
> > > >  		 " --stop-address=0x%016" PRIx64
> > > > -		 " -l -d %s %s -C %s 2>/dev/null|grep -v %s|expand",
> > > > +		 " -l -d %s %s -C %s 2>/dev/null|grep -v %s: |expand",
> 
> > > Are you sure this works as you expect? I.e. both lines will have '%s:'
>  
> > Yes, if we do, we can exactly the only below line without the side effect
> > IMHO.
> 
> yeah, because the .c is not there, ok gotcha, will get your new commit
> log message, massage it a bit and apply the patch.

Nah, with all this in mind, the original message is good enough, sorry
for the confusion with the .c and the space after ':' (that I removed,
needless and potentially confusing, as we saw here).

- Arnaldo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] perf annotate: Bugfixes Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
  [PATCH 3/4] perf annotate: Fix missing setting nr samples on source_line Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
  [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
    Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:50 +0100
      Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 17:30 +0100
        Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
          Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 08:40 +0100
        Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
      Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <taeung.dev@gmail.com> - 2017-03-21 17:30 +0100
    [tip:perf/core] perf annotate: More exactly grep -v of the objdump  command tip-bot for Taeung Song <tipbot@zytor.com> - 2017-03-24 20:00 +0100
  [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
    Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-20 19:20 +0100
      Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:20 +0100
        Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:30 +0100
          Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:20 +0100
            Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:40 +0100
              Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 15:50 +0100
              Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 13:10 +0100

csiph-web