Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604159

[PATCH 2/4] perf annotate: Avoid division by zero when calculating percent

From Taeung Song <treeze.taeung@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent
Date 2017-03-20 04:00 +0100
Message-ID <tmVI6-6BY-13@gated-at.bofh.it> (permalink)
References <tmVI5-6BY-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Currently perf-annotate with --print-line can print
-nan(0x8000000000000) because of division by zero
when calculating percent.

So if a sum of samples is zero, skip calculating percent.

Before:

    $ perf annotate --stdio -l

Sorted summary for file /home/taeung/workspace/a.out
----------------------------------------------

   32.89    -nan    7.04 a.c:38
   25.14    -nan    0.00 a.c:34
   16.26    -nan   56.34 a.c:31
   15.88    -nan    1.41 a.c:37
    5.67    -nan    0.00 a.c:39
    1.13    -nan   35.21 a.c:26
    0.95    -nan    0.00 a.c:44
    0.57    -nan    0.00 a.c:32
 Percent                 |      Source code & Disassembly of a.out for cycles (529 samples)
-----------------------------------------------------------------------------------------
                         :
...

 a.c:26    0.57    -nan    4.23 :         40081a:       mov    %edi,-0x24(%rbp)
 a.c:26    0.00    -nan    9.86 :         40081d:       mov    %rsi,-0x30(%rbp)

...

After:

    $ perf annotate --stdio -l

Sorted summary for file /home/taeung/workspace/a.out
----------------------------------------------

   32.89    0.00    7.04 a.c:38
   25.14    0.00    0.00 a.c:34
   16.26    0.00   56.34 a.c:31
   15.88    0.00    1.41 a.c:37
    5.67    0.00    0.00 a.c:39
    1.13    0.00   35.21 a.c:26
    0.95    0.00    0.00 a.c:44
    0.57    0.00    0.00 a.c:32
 Percent                 |      Source code & Disassembly of old for cycles (529 samples)
-----------------------------------------------------------------------------------------
                         :
...

a.c:26    0.57    0.00    4.23 :         40081a:       mov    %edi,-0x24(%rbp)
a.c:26    0.00    0.00    9.86 :         40081d:       mov    %rsi,-0x30(%rbp)

...

Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/util/annotate.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index fc91c6b..9bb43cd 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1665,11 +1665,15 @@ static int symbol__get_source_line(struct symbol *sym, struct map *map,
 		src_line->nr_pcnt = nr_pcnt;
 
 		for (k = 0; k < nr_pcnt; k++) {
+			double percent = 0.0;
+
 			h = annotation__histogram(notes, evidx + k);
-			src_line->samples[k].percent = 100.0 * h->addr[i] / h->sum;
+			if (h->sum)
+				percent = 100.0 * h->addr[i] / h->sum;
 
-			if (src_line->samples[k].percent > percent_max)
-				percent_max = src_line->samples[k].percent;
+			if (percent > percent_max)
+				percent_max = percent;
+			src_line->samples[k].percent = percent;
 		}
 
 		if (percent_max <= 0.5)
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] perf annotate: Bugfixes Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
  [PATCH 3/4] perf annotate: Fix missing setting nr samples on source_line Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
  [PATCH 4/4] perf annotate: More exactly grep -v of the objdump command Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
    Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:50 +0100
      Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 17:30 +0100
        Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
          Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 08:40 +0100
        Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 19:40 +0100
      Re: [PATCH 4/4] perf annotate: More exactly grep -v of the objdump  command Taeung Song <taeung.dev@gmail.com> - 2017-03-21 17:30 +0100
    [tip:perf/core] perf annotate: More exactly grep -v of the objdump  command tip-bot for Taeung Song <tipbot@zytor.com> - 2017-03-24 20:00 +0100
  [PATCH 2/4] perf annotate: Avoid division by zero when calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 04:00 +0100
    Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-20 19:20 +0100
      Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:20 +0100
        Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-20 23:30 +0100
          Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:20 +0100
            Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-03-21 15:40 +0100
              Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-21 15:50 +0100
              Re: [PATCH 2/4] perf annotate: Avoid division by zero when  calculating percent Taeung Song <treeze.taeung@gmail.com> - 2017-03-22 13:10 +0100

csiph-web