Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605550

Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG

From Will Deacon <will.deacon@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date 2017-03-21 13:10 +0100
Message-ID <tnqLU-39H-23@gated-at.bofh.it> (permalink)
References <tl2ul-6hH-1@gated-at.bofh.it> <tnaQO-K7-13@gated-at.bofh.it> <tnpmO-24D-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 21, 2017 at 11:35:16AM +0100, Arnd Bergmann wrote:
> On Mon, Mar 20, 2017 at 8:09 PM, Will Deacon <will.deacon@arm.com> wrote:
> 
> >>
> >> -#define BUG() do {                           \
> >> -     _BUG_FLAGS(0);                          \
> >> -     unreachable();                          \
> >> +#define _BUG_FLAGS(flags) __BUG_FLAGS(flags)
> >
> > What is this for? I don't see _BUG_FLAGS used anywhere, but I could
> > be missing some macro expansion.
> 
> I think I accidentally left this after removing the last user from an
> intermediate
> version of the patch. Do you want me to send an updated version, or could
> you just drop this line when applying?

I suspect Catalin can do that when he takes the patch. With that fixup:

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks,

Will

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:50 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-20 20:10 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-21 11:40 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-21 13:10 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-21 15:20 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 15:40 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 16:00 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 16:50 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 17:30 +0100
          Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 18:00 +0100

csiph-web