Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date	2017-03-22 16:50 +0100
Message-ID	<tnQGm-4KM-5@gated-at.bofh.it> (permalink)
References	<tl2ul-6hH-1@gated-at.bofh.it> <tnPAD-3OD-39@gated-at.bofh.it> <tnPTY-3ZD-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 03:51:54PM +0100, Arnd Bergmann wrote:
> On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
> > Hi Arnd,
> >
> > On Tue, Mar 14, 2017 at 10:39:21PM +0100, Arnd Bergmann wrote:
> >> This mirrors commit e9c38ceba8d9 ("ARM: 8455/1: define __BUG as
> >> asm(BUG_INSTR) without CONFIG_BUG") to make the behavior of
> >> arm64 consistent with arm and x86, and avoids lots of warnings in
> >> randconfig builds, such as:
> >>
> >> kernel/seccomp.c: In function '__seccomp_filter':
> >> kernel/seccomp.c:666:1: error: no return statement in function returning non-void [-Werror=return-type]
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > A side-effect of this patch is that it turns WARN into BUG. I hit the
> > WARN_ONCE in arch/arm64/kernel/efi.c:34 (on Juno with 64K pages) and
> > with your patch applied, the kernel panics.
> 
> Taht was certainly not intended, and I don't see yet what exactly is going on.
> What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE?

CONFIG_BUG=y
CONFIG_DEBUG_BUGVERBOSE=y

(just defconfig + 64K pages)

-- 
Catalin

Thread

[PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:50 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-20 20:10 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-21 11:40 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-21 13:10 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-21 15:20 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 15:40 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 16:00 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 16:50 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 17:30 +0100
          Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 18:00 +0100

csiph-web