Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606723

Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG
Date 2017-03-22 17:30 +0100
Message-ID <tnRj3-5ko-9@gated-at.bofh.it> (permalink)
References <tl2ul-6hH-1@gated-at.bofh.it> <tnPAD-3OD-39@gated-at.bofh.it> <tnPTY-3ZD-7@gated-at.bofh.it> <tnQGm-4KM-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 22, 2017 at 4:32 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> On Wed, Mar 22, 2017 at 03:51:54PM +0100, Arnd Bergmann wrote:
>> On Wed, Mar 22, 2017 at 3:37 PM, Catalin Marinas
>> <catalin.marinas@arm.com> wrote:

>> Taht was certainly not intended, and I don't see yet what exactly is going on.
>> What is your setting for CONFIG_BUG and CONFIG_BUGVERBOSE?
>
> CONFIG_BUG=y
> CONFIG_DEBUG_BUGVERBOSE=y

Ok, I found the typo, can you just fold this in, or should I send an
updated patch?

 Arnd

diff --git a/arch/arm64/include/asm/bug.h b/arch/arm64/include/asm/bug.h
index bfc6021760e5..ff030254f791 100644
--- a/arch/arm64/include/asm/bug.h
+++ b/arch/arm64/include/asm/bug.h
@@ -49,10 +49,10 @@ _BUGVERBOSE_LOCATION(__FILE__, __LINE__) \

 #define __BUG_FLAGS(flags) \
  asm volatile ( \
- __BUG_ENTRY(0) \
+ __BUG_ENTRY(flags) \
  "brk %[imm]" :: [imm] "i" (BUG_BRK_IMM) \
  );

 #define BUG() do { \
  __BUG_FLAGS(0); \
  unreachable(); \

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-14 22:50 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-20 20:10 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-21 11:40 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Will Deacon <will.deacon@arm.com> - 2017-03-21 13:10 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-21 15:20 +0100
  Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 15:40 +0100
    Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 16:00 +0100
      Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 16:50 +0100
        Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Arnd Bergmann <arnd@arndb.de> - 2017-03-22 17:30 +0100
          Re: [PATCH] [v2] arm64: define BUG() instruction without CONFIG_BUG Catalin Marinas <catalin.marinas@arm.com> - 2017-03-22 18:00 +0100

csiph-web