Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments
Date	2017-03-22 15:20 +0100
Message-ID	<tnPhf-3Fu-15@gated-at.bofh.it> (permalink)
References	<tjzkK-Cj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 10, 2017 at 12:23:41PM -0800, Joel Fernandes wrote:
> The PELT decay_load comments are a bit confusing, first of all
> the 1/2^N should be (1/2)^N so that the reader doesn't get confused.

I'm thinking you're confused. They're identical.

(1/2)^N = (2^-1)^N = 2^-N = 1/2^N

> Secondly, the y^N splitting into a 2-part decay factor deserves
> a better explanation. This patch improves the comments.

I find its actually harder to read.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments Peter Zijlstra <peterz@infradead.org> - 2017-03-22 15:20 +0100
  Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments Joel Fernandes <joelaf@google.com> - 2017-03-22 17:40 +0100
    Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments Peter Zijlstra <peterz@infradead.org> - 2017-03-22 18:10 +0100
      Re: [PATCH] sched: fair: Improve PELT decay_load calculation comments Joel Fernandes <joelaf@google.com> - 2017-03-22 20:20 +0100

csiph-web