Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units
Date	Wed, 15 Mar 2017 11:20:03 +0100
Message-ID	<tleca-6cz-39@gated-at.bofh.it> (permalink)
References	<tkDvY-501-21@gated-at.bofh.it> <tkWff-1T2-9@gated-at.bofh.it> <tkWyD-20n-49@gated-at.bofh.it>
X-Original-To	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nL9g+0I8c1tOC6MKC8hCLpoxZToPG1xDolwnRQCu1sM=; b=GXOxT1yMY+U7jzymd+rYRrJ82kpEtU0HFgWTFHNtTbSEEWW9+J3VkyDL/UhsPJslAa xxKZIkZrZCJfXQej2EtsgEcfDPTbXAYnpOTirmAtYnrE5K2kpzkppN2rPBtdjZvA9pGK +5DwRgFg9rxIXnZJ+8tvG4SkrPz5Wfn4/CKqQ=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nL9g+0I8c1tOC6MKC8hCLpoxZToPG1xDolwnRQCu1sM=; b=sasuC5d7Lm/Ev3o8vhuF4vxm/sJID482Wb4i72hHSDlK28y+2/LcJeEbz8U2QKMcN+ T/AaJm/tiS0Z7aIqukFZ51udgMvuzSG1Bob5iWvacAsE9e0KAdF+9U/BjvzfrPQDAQRm nEcPHPqDmi5l2u/vd9lVRFAiVRDcT5pc5oAwICwVNUflKO/jKBy4JvsO6VqTLO1O7RTG GhDatSDK8jJ99GrF470VGE6uwSVUeRXIUtfAcB1zKgvYIhQp65oN8NM/XqicP9SvlIhS 8TDhR+AFQXwymLe0P93fpM9Zd0QQEF48NZW7ybAutb7JqsHxKqbjs3HMxPvUo2Q4vOj7 e/aA==
X-Gm-Message-State	AFeK/H15lVdrgF5ZTsa9qUmxcvUfjtw7MQ4BMbCUX7cAO30YwF4JV55RCSXeFT1S4wEYlQH3
X-Received	by 10.28.129.83 with SMTP id c80mr17939756wmd.82.1489572737535; Wed, 15 Mar 2017 03:12:17 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.6.2-neo (2016-08-21)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Wed, 15 Mar 2017 10:12:15 +0000
X-Original-Message-ID	<20170315101215.svmi4tyzyql2bze5@dell>
X-Original-References	<20170313190727.8069-1-andriy.shevchenko@linux.intel.com> <20170314150234.z4omelqdwox5tts4@dell> <1489504914.20145.247.camel@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601235

Show key headers only | View raw

On Tue, 14 Mar 2017, Andy Shevchenko wrote:

> On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote:
> > On Mon, 13 Mar 2017, Andy Shevchenko wrote:
> > 
> > > Crystal Cove and Whiskey Cove are two different PMICs which are
> > > installed on Intel Atom SoC based platforms.
> > > 
> > > Moreover there are two independent drivers that by some reason are
> > > supposed (*) to get into one kernel module.
> > > 
> > > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > > Whiskey Cove out of it.
> > > 
> > > (*) It looks like the configuration was never ever tested. The line
> > > in
> > >     Makefile is actually wrong.
>  
> > >  config INTEL_SOC_PMIC
> > > -	bool "Support for Intel Atom SoC PMIC"
> > > +	bool "Support for Crystal Cove PMIC"
> > >  	depends on GPIOLIB
> > >  	depends on I2C=y
> > >  	select MFD_CORE
> > >  	select REGMAP_I2C
> > >  	select REGMAP_IRQ
> > >  	help
> > > -	  Select this option to enable support for the PMIC device
> > > +	  Select this option to enable support for Crystal Cove
> > > PMIC
> > >  	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
> > >  	  thermal, charger and related power management functions
> > >  	  on these systems.
> > >  
> > > +config INTEL_SOC_PMIC_BXTWC
> > > +	tristate
> > > +	select MFD_CORE
> > > +	select REGMAP_IRQ
> > 
> > I think you need to make mention that this is Whiskey Cove?
> 
> It's selectable option, so I don't know if it's a good idea to make it
> visible to the user. Or do you mean fill the help section only?

I think you just answered your own question. :)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Thread

Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-14 16:10 +0100
  Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation  units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-14 16:30 +0100
    Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-15 11:20 +0100
      Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation  units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-17 16:10 +0100

csiph-web