Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600608

Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units

Show all headers | View raw

On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote:
> On Mon, 13 Mar 2017, Andy Shevchenko wrote:
> 
> > Crystal Cove and Whiskey Cove are two different PMICs which are
> > installed on Intel Atom SoC based platforms.
> > 
> > Moreover there are two independent drivers that by some reason are
> > supposed (*) to get into one kernel module.
> > 
> > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > Whiskey Cove out of it.
> > 
> > (*) It looks like the configuration was never ever tested. The line
> > in
> >     Makefile is actually wrong.
 
> >  config INTEL_SOC_PMIC
> > -	bool "Support for Intel Atom SoC PMIC"
> > +	bool "Support for Crystal Cove PMIC"
> >  	depends on GPIOLIB
> >  	depends on I2C=y
> >  	select MFD_CORE
> >  	select REGMAP_I2C
> >  	select REGMAP_IRQ
> >  	help
> > -	  Select this option to enable support for the PMIC device
> > +	  Select this option to enable support for Crystal Cove
> > PMIC
> >  	  on some Intel SoC systems. The PMIC provides ADC, GPIO,
> >  	  thermal, charger and related power management functions
> >  	  on these systems.
> >  
> > +config INTEL_SOC_PMIC_BXTWC
> > +	tristate
> > +	select MFD_CORE
> > +	select REGMAP_IRQ
> 
> I think you need to make mention that this is Whiskey Cove?

It's selectable option, so I don't know if it's a good idea to make it
visible to the user. Or do you mean fill the help section only?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-14 16:10 +0100
  Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation  units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-14 16:30 +0100
    Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-15 11:20 +0100
      Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation  units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-17 16:10 +0100

csiph-web