Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1600548 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2017-03-14 16:10 +0100 |
| Last post | 2017-03-17 16:10 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-14 16:10 +0100
Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-14 16:30 +0100
Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Lee Jones <lee.jones@linaro.org> - 2017-03-15 11:20 +0100
Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-17 16:10 +0100
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-03-14 16:10 +0100 |
| Subject | Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units |
| Message-ID | <tkWff-1T2-9@gated-at.bofh.it> |
On Mon, 13 Mar 2017, Andy Shevchenko wrote: > Crystal Cove and Whiskey Cove are two different PMICs which are > installed on Intel Atom SoC based platforms. > > Moreover there are two independent drivers that by some reason are > supposed (*) to get into one kernel module. > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > Whiskey Cove out of it. > > (*) It looks like the configuration was never ever tested. The line in > Makefile is actually wrong. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/mfd/Kconfig | 9 +++++++-- > drivers/mfd/Makefile | 2 +- > drivers/platform/x86/Kconfig | 1 + > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 55ecdfb74d31..83609acd55ef 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -425,18 +425,23 @@ config LPC_SCH > System Management Bus and General Purpose I/O. > > config INTEL_SOC_PMIC > - bool "Support for Intel Atom SoC PMIC" > + bool "Support for Crystal Cove PMIC" > depends on GPIOLIB > depends on I2C=y > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > help > - Select this option to enable support for the PMIC device > + Select this option to enable support for Crystal Cove PMIC > on some Intel SoC systems. The PMIC provides ADC, GPIO, > thermal, charger and related power management functions > on these systems. > > +config INTEL_SOC_PMIC_BXTWC > + tristate > + select MFD_CORE > + select REGMAP_IRQ I think you need to make mention that this is Whiskey Cove? > config MFD_INTEL_LPSS > tristate > select COMMON_CLK > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 31ce07611a6f..201aeaf5112a 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -207,8 +207,8 @@ obj-$(CONFIG_MFD_RT5033) += rt5033.o > obj-$(CONFIG_MFD_SKY81452) += sky81452.o > > intel-soc-pmic-objs := intel_soc_pmic_core.o intel_soc_pmic_crc.o > -intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC) += intel_soc_pmic_bxtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC) += intel-soc-pmic.o > +obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) += intel_soc_pmic_bxtwc.o > obj-$(CONFIG_MFD_MT6397) += mt6397-core.o > > obj-$(CONFIG_MFD_ALTERA_A10SR) += altera-a10sr.o > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index e1bffc9bb194..afbff6d9834b 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1011,6 +1011,7 @@ config PVPANIC > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > depends on ACPI > + select INTEL_SOC_PMIC_BXTWC > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2017-03-14 16:30 +0100 |
| Subject | Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units |
| Message-ID | <tkWyD-20n-49@gated-at.bofh.it> |
| In reply to | #1600548 |
On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote: > On Mon, 13 Mar 2017, Andy Shevchenko wrote: > > > Crystal Cove and Whiskey Cove are two different PMICs which are > > installed on Intel Atom SoC based platforms. > > > > Moreover there are two independent drivers that by some reason are > > supposed (*) to get into one kernel module. > > > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > > Whiskey Cove out of it. > > > > (*) It looks like the configuration was never ever tested. The line > > in > > Makefile is actually wrong. > > config INTEL_SOC_PMIC > > - bool "Support for Intel Atom SoC PMIC" > > + bool "Support for Crystal Cove PMIC" > > depends on GPIOLIB > > depends on I2C=y > > select MFD_CORE > > select REGMAP_I2C > > select REGMAP_IRQ > > help > > - Select this option to enable support for the PMIC device > > + Select this option to enable support for Crystal Cove > > PMIC > > on some Intel SoC systems. The PMIC provides ADC, GPIO, > > thermal, charger and related power management functions > > on these systems. > > > > +config INTEL_SOC_PMIC_BXTWC > > + tristate > > + select MFD_CORE > > + select REGMAP_IRQ > > I think you need to make mention that this is Whiskey Cove? It's selectable option, so I don't know if it's a good idea to make it visible to the user. Or do you mean fill the help section only? -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-03-15 11:20 +0100 |
| Message-ID | <tleca-6cz-39@gated-at.bofh.it> |
| In reply to | #1600608 |
On Tue, 14 Mar 2017, Andy Shevchenko wrote: > On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote: > > On Mon, 13 Mar 2017, Andy Shevchenko wrote: > > > > > Crystal Cove and Whiskey Cove are two different PMICs which are > > > installed on Intel Atom SoC based platforms. > > > > > > Moreover there are two independent drivers that by some reason are > > > supposed (*) to get into one kernel module. > > > > > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never ever tested. The line > > > in > > > Makefile is actually wrong. > > > > config INTEL_SOC_PMIC > > > - bool "Support for Intel Atom SoC PMIC" > > > + bool "Support for Crystal Cove PMIC" > > > depends on GPIOLIB > > > depends on I2C=y > > > select MFD_CORE > > > select REGMAP_I2C > > > select REGMAP_IRQ > > > help > > > - Select this option to enable support for the PMIC device > > > + Select this option to enable support for Crystal Cove > > > PMIC > > > on some Intel SoC systems. The PMIC provides ADC, GPIO, > > > thermal, charger and related power management functions > > > on these systems. > > > > > > +config INTEL_SOC_PMIC_BXTWC > > > + tristate > > > + select MFD_CORE > > > + select REGMAP_IRQ > > > > I think you need to make mention that this is Whiskey Cove? > > It's selectable option, so I don't know if it's a good idea to make it > visible to the user. Or do you mean fill the help section only? I think you just answered your own question. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2017-03-17 16:10 +0100 |
| Subject | Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units |
| Message-ID | <tm1FT-8kN-9@gated-at.bofh.it> |
| In reply to | #1601235 |
On Wed, 2017-03-15 at 10:12 +0000, Lee Jones wrote: > On Tue, 14 Mar 2017, Andy Shevchenko wrote: > > > > +config INTEL_SOC_PMIC_BXTWC > > > > + tristate > > > > + select MFD_CORE > > > > + select REGMAP_IRQ > > > > > > I think you need to make mention that this is Whiskey Cove? > > > > It's selectable option, so I don't know if it's a good idea to make > > it > > visible to the user. Or do you mean fill the help section only? > > I think you just answered your own question. :) Since Hans is going to make Cherry Trail Whiskey Cove module user visible I do it here for sake of consistency. I'm about to send v3 then. -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web