Re: [PATCH v4 0/5] perf report: Show inline stack

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Milian Wolff <milian.wolff@kdab.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/5] perf report: Show inline stack
Date	Wed, 15 Mar 2017 11:20:02 +0100
Message-ID	<tleca-6cz-35@gated-at.bofh.it> (permalink)
References	<tgLs6-2V8-1@gated-at.bofh.it>
X-Original-To	Jin Yao <yao.jin@linux.intel.com>
Organization	KDAB
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
X-Original-Cc	acme@kernel.org, jolsa@kernel.org, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com
X-Original-Date	Tue, 14 Mar 2017 13:59:55 +0100
X-Original-Message-ID	<148956608.Gr0Z3zOxTt@milian-kdab2>
X-Original-References	<1488537785-10684-1-git-send-email-yao.jin@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1601234

Show key headers only | View raw

On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
> v4: Remove the options "--inline-line" and "--inline-name". Just use
>     a new option "--inline" to print the inline function information.
>     The policy is if the inline function name can be resolved then
>     print the name in priority. If the name can't be resolved, then
>     print the source line number.

This is still wrong from a usability POV. I may want to see the file/line for 
entry that have a name. And actually, there are afaik no situations where you 
could have a file/line but not a symbol name.

Again, why don't you align this with the other non-inlined frames, and honor 
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).

Bye
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/5] perf report: Show inline stack Milian Wolff <milian.wolff@kdab.com> - 2017-03-15 11:20 +0100
  Re: [PATCH v4 0/5] perf report: Show inline stack "Jin, Yao" <yao.jin@linux.intel.com> - 2017-03-16 14:50 +0100

csiph-web