Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601234 > unrolled thread

Re: [PATCH v4 0/5] perf report: Show inline stack

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 0/5] perf report: Show inline stack Milian Wolff <milian.wolff@kdab.com> - 2017-03-15 11:20 +0100
    Re: [PATCH v4 0/5] perf report: Show inline stack "Jin, Yao" <yao.jin@linux.intel.com> - 2017-03-16 14:50 +0100

#1601234 — Re: [PATCH v4 0/5] perf report: Show inline stack

On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
> v4: Remove the options "--inline-line" and "--inline-name". Just use
>     a new option "--inline" to print the inline function information.
>     The policy is if the inline function name can be resolved then
>     print the name in priority. If the name can't be resolved, then
>     print the source line number.

This is still wrong from a usability POV. I may want to see the file/line for 
entry that have a name. And actually, there are afaik no situations where you 
could have a file/line but not a symbol name.

Again, why don't you align this with the other non-inlined frames, and honor 
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).

Bye
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[toc] | [next] | [standalone]

#1602290

Hi Wolff,

Thanks so much for your review comments!

I just send out the v5 patch series. The patch series are updated 
according to your comments.

Thanks

Jin Yao

On 3/14/2017 8:59 PM, Milian Wolff wrote:
> On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
>> v4: Remove the options "--inline-line" and "--inline-name". Just use
>>      a new option "--inline" to print the inline function information.
>>      The policy is if the inline function name can be resolved then
>>      print the name in priority. If the name can't be resolved, then
>>      print the source line number.
> This is still wrong from a usability POV. I may want to see the file/line for
> entry that have a name. And actually, there are afaik no situations where you
> could have a file/line but not a symbol name.
>
> Again, why don't you align this with the other non-inlined frames, and honor
> the grouping setting? Check whether we group by address (then display file/
> line), or by function (then display the function name).
>
> Bye

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web