Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602290

Re: [PATCH v4 0/5] perf report: Show inline stack

Show all headers | View raw

Hi Wolff,

Thanks so much for your review comments!

I just send out the v5 patch series. The patch series are updated 
according to your comments.

Thanks

Jin Yao

On 3/14/2017 8:59 PM, Milian Wolff wrote:
> On Friday, March 3, 2017 11:43:00 AM CET Jin Yao wrote:
>> v4: Remove the options "--inline-line" and "--inline-name". Just use
>>      a new option "--inline" to print the inline function information.
>>      The policy is if the inline function name can be resolved then
>>      print the name in priority. If the name can't be resolved, then
>>      print the source line number.
> This is still wrong from a usability POV. I may want to see the file/line for
> entry that have a name. And actually, there are afaik no situations where you
> could have a file/line but not a symbol name.
>
> Again, why don't you align this with the other non-inlined frames, and honor
> the grouping setting? Check whether we group by address (then display file/
> line), or by function (then display the function name).
>
> Bye

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 0/5] perf report: Show inline stack Milian Wolff <milian.wolff@kdab.com> - 2017-03-15 11:20 +0100
  Re: [PATCH v4 0/5] perf report: Show inline stack "Jin, Yao" <yao.jin@linux.intel.com> - 2017-03-16 14:50 +0100

csiph-web