Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1601214

Re: [PATCH] net: sun: sungem: rix a possible null dereference

Path csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Newsgroups linux.kernel
Subject Re: [PATCH] net: sun: sungem: rix a possible null dereference
Date Wed, 15 Mar 2017 11:10:02 +0100
Message-ID <tle2u-689-11@gated-at.bofh.it> (permalink)
References <tl2b1-66f-41@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=x9QfZE/600BNdZV79VVAjBq1/KwV31PNFAjHyALCA2g=; b=ZUComUe/wTlQK/rDRl2fnt6poEV0Z90pENald2wK1gMavkCjBEgX4CggSoDnvE3X67 E4rS/RNuJbxiEUUSSRUbpZ/vrkdYkSheUkATOdjBOq9tiZHZAy9h9X4wUAymUifTZEAi 6CihXlGVtp1robLtyqbEn6Z7mVR2VDSepKFUUpUn+E6oGrpgPGXKI9tdGFd0TSYDo+GI ItsoIwu7GRq+uV7k+ZjmjEBk4Vhg7D5xkb/Q++iijoCaeq/8AE25QFCqAEx8sC53/I82 Nosxxp3thyD/XTgQ0JS49g32Q9mXtFx8IsM75m7QSGvzPHlhaFrG303YA5+gOU8+4Ekf VL9Q==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=x9QfZE/600BNdZV79VVAjBq1/KwV31PNFAjHyALCA2g=; b=Kk26CEYDbFa5vfCTEdA4uBPDffBCWmYEiGcIbxeMWB0gOWLOxQAVW6fM5zWKlbWmym duqacSorv0Q2l0ffF1hVffenri5EArSKncXYF8Iz20gBF5BmGDRJcuI7fKIGohQ2Yz/W RJIcy7gkK2OMHEFXAwxzjyDOjtslVQ2jZbPE3tEdxGNLpjYYA0SfbB7Yb4qnw9cPFJPY enbrLjuxvHXNH2s9VhWhgCZYx2N5hHa1K/s5JZ9F3/iOlUgPkvab1QwzgsvysyeOO7VZ R/H2B558QqmFYzBgS6mAapF7/3OO7GeL4k2j2jld5gE9dVtaExFpCF4jG1hEQhMJlzLn oqaQ==
X-Gm-Message-State AFeK/H0inyUkKkouMRPMFjJiQ9PbWFNQB2hAmdtDYMghWwX5jZrPfaREGYpIzwmHaaEDjQ==
X-Received by 10.25.25.80 with SMTP id 77mr681818lfz.64.1489572326455; Wed, 15 Mar 2017 03:05:26 -0700 (PDT)
User-Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version 1.0
Content-Type text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 19
Organization linux.* mail to news gateway
X-Original-Cc netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Wed, 15 Mar 2017 13:05:24 +0300
X-Original-Message-ID <88708a0d-7b8a-b1d7-ee66-fd51c6bfe0fe@cogentembedded.com>
X-Original-References <1489526601-9423-1-git-send-email-tremyfr@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1601214

Show key headers only | View raw


Hello!

On 3/15/2017 12:23 AM, Philippe Reynes wrote:

> The function gem_begin_auto_negotiation dereference
> the pointer ep before testing if it's null. This
> patch add a check on ep before dereferencing it.
>
> This issue was added by the patch 92552fdd557:
> "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings".

    There's Fixes: tag for that now, described in 
Documentation/process/submitting-patches.rst...

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
[...]

MBR, Sergei

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-14 22:30 +0100
  Re: [PATCH] net: sun: sungem: rix a possible null dereference Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-15 11:10 +0100
    Re: [PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-15 22:50 +0100

csiph-web