Re: [PATCH] net: sun: sungem: rix a possible null dereference

From	Philippe Reynes <tremyfr@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: sun: sungem: rix a possible null dereference
Date	2017-03-15 22:50 +0100
Message-ID	<tloXT-59Y-13@gated-at.bofh.it> (permalink)
References	<tl2b1-66f-41@gated-at.bofh.it> <tle2u-689-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sergei,

On 3/15/17, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> Hello!
>
> On 3/15/2017 12:23 AM, Philippe Reynes wrote:
>
>> The function gem_begin_auto_negotiation dereference
>> the pointer ep before testing if it's null. This
>> patch add a check on ep before dereferencing it.
>>
>> This issue was added by the patch 92552fdd557:
>> "net: sun: sungem: use new api ethtool_{get|set}_link_ksettings".
>
>     There's Fixes: tag for that now, described in
> Documentation/process/submitting-patches.rst...

Thanks a lot for pointing me this tag.
I'm sending a v2 of this patch with this tag.

>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> [...]
>
> MBR, Sergei
>

Thanks,
Philippe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-14 22:30 +0100
  Re: [PATCH] net: sun: sungem: rix a possible null dereference Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-03-15 11:10 +0100
    Re: [PATCH] net: sun: sungem: rix a possible null dereference Philippe Reynes <tremyfr@gmail.com> - 2017-03-15 22:50 +0100

csiph-web