Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1602750

Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID

Show all headers | View raw

On Thu, Mar 16, 2017 at 7:30 AM, Kyle Huey <me@kylehuey.com> wrote:
> On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>
>> Presumably he's done:
>>
>> $ git config diff.context 8
>
> Indeed.  In my case it dates back to my days hacking on Firefox, which
> wants 8 lines of context for patches.  I'll remove it.

You can make those kinds of options per-repository rather than
user-global, so you can keep the 8-line thing for firefox without
having it for the kernel.

Not that it *hurts* for the kernel, but it just looked odd to me
because the patch looked so much bigger. More context lines can
obviously help with ambiguous cases, but we very seldom have that kind
of ambiguity.

I'm assuming firefox has files that have lots and lots of repeated
lines (or things like autogenerated content with a lot of common
boilerplate or whatever), which is why they like lots of context?

                     Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-14 22:50 +0100
  Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 12:20 +0100
    Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Kyle Huey <me@kylehuey.com> - 2017-03-16 16:10 +0100
      Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:30 +0100
        Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-17 09:00 +0100

csiph-web