Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET\|SET]_CPUID
Date	2017-03-14 22:50 +0100
Message-ID	<tl2ul-6hH-3@gated-at.bofh.it> (permalink)
References	<tjVbA-7mC-3@gated-at.bofh.it> <tjVbA-7mC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Kyle,
 your patch format is really odd.

You seem to have *eight* lines of context rather than the regular 3.
Is there any reason for that oddity?

It basically means that a one-line hunk ends up being 17 lines of
unified diff rather than 7.

Example appended,

                  Linus

On Sat, Mar 11, 2017 at 11:46 AM, Kyle Huey <me@kylehuey.com> wrote:
>
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
> index ad6f5eb07a95..9fc44b95f7cb 100644
> --- a/arch/x86/include/asm/thread_info.h
> +++ b/arch/x86/include/asm/thread_info.h
> @@ -82,16 +82,17 @@ struct thread_info {
>  #define TIF_SIGPENDING         2       /* signal pending */
>  #define TIF_NEED_RESCHED       3       /* rescheduling necessary */
>  #define TIF_SINGLESTEP         4       /* reenable singlestep on user return*/
>  #define TIF_SYSCALL_EMU                6       /* syscall emulation active */
>  #define TIF_SYSCALL_AUDIT      7       /* syscall auditing active */
>  #define TIF_SECCOMP            8       /* secure computing */
>  #define TIF_USER_RETURN_NOTIFY 11      /* notify kernel of userspace return */
>  #define TIF_UPROBE             12      /* breakpointed or singlestepping */
> +#define TIF_NOCPUID            15      /* CPUID is not accessible in userland */
>  #define TIF_NOTSC              16      /* TSC is not accessible in userland */
>  #define TIF_IA32               17      /* IA32 compatibility process */
>  #define TIF_NOHZ               19      /* in adaptive nohz mode */
>  #define TIF_MEMDIE             20      /* is terminating due to OOM killer */
>  #define TIF_POLLING_NRFLAG     21      /* idle is polling for TIF_NEED_RESCHED */
>  #define TIF_IO_BITMAP          22      /* uses I/O bitmap */
>  #define TIF_FORCED_TF          24      /* true if TF in eflags artificially */
>  #define TIF_BLOCKSTEP          25      /* set when we want DEBUGCTLMSR_BTF */

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-14 22:50 +0100
  Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 12:20 +0100
    Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Kyle Huey <me@kylehuey.com> - 2017-03-16 16:10 +0100
      Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:30 +0100
        Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-17 09:00 +0100

csiph-web