Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID

From	Kyle Huey <me@kylehuey.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET\|SET]_CPUID
Date	2017-03-16 16:10 +0100
Message-ID	<tlFcp-97-83@gated-at.bofh.it> (permalink)
References	<tjVbA-7mC-3@gated-at.bofh.it> <tjVbA-7mC-1@gated-at.bofh.it> <tl2ul-6hH-3@gated-at.bofh.it> <tlBBM-5Uw-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 16, 2017 at 4:09 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> Kyle,
>>  your patch format is really odd.
>>
>> You seem to have *eight* lines of context rather than the regular 3.
>> Is there any reason for that oddity?
>>
>> It basically means that a one-line hunk ends up being 17 lines of
>> unified diff rather than 7.
>
> Presumably he's done:
>
> $ git config diff.context 8
>
>
> Which I also did at one point because I thought it might help for
> reading diffs, but reverted after realising it also affects the diffs
> that are generated by format-patch etc.
>
> cheers

Indeed.  In my case it dates back to my days hacking on Firefox, which
wants 8 lines of context for patches.  I'll remove it.

- Kyle

Thread

Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-14 22:50 +0100
  Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Michael Ellerman <mpe@ellerman.id.au> - 2017-03-16 12:20 +0100
    Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Kyle Huey <me@kylehuey.com> - 2017-03-16 16:10 +0100
      Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Linus Torvalds <torvalds@linux-foundation.org> - 2017-03-16 19:30 +0100
        Re: [PATCH v15 6/9] x86/arch_prctl: Add ARCH_[GET|SET]_CPUID Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-17 09:00 +0100

csiph-web