Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary
Date	Mon, 13 Mar 2017 12:20:02 +0100
Message-ID	<tkwb8-8aF-9@gated-at.bofh.it> (permalink)
References	<tkusH-6Sd-35@gated-at.bofh.it>
X-Original-To	Hans de Goede <hdegoede@redhat.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=02HUVhrdu4RUOsF3cIwA4F1pV7YUip2z/C7WGTthaHM=; b=fSX7htJyh0smpUhU18TnM/hKcVJ+zFMCJpa5DbbX6H6wpdBh9ZvPqEcRA/hsOrSeDe 78oBKGGMV2SaVZCG7K40umQ6457HwXmJqUcoxAUeV8LdisYrgPtlou7O+pJc2z+mciMy 7xzkh5UkhJikOLrMlVSjZpOyrFGk7aNtRAaSRTAvaleKfJoOaVlFHDvSfFvts4AICJCu 3GJzmHUK00C3qBEBhakHjsl01nUFRZXX23qrmAHpBb8dz0lNcZHT8JA9BNJQbCwApeAp MifVZEYWs+njETrID+SwqbxSfwFlwqQcb4Wa0Lx5v94asLC+Xo8KPEP+m2rLaynmX4c1 /tJA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=02HUVhrdu4RUOsF3cIwA4F1pV7YUip2z/C7WGTthaHM=; b=iUtqGWuz70AcxHMiQERIBDJfwQChGr1KPDqJSWzXn6nc900clhGI9EbP4GcQewyVHW ZzTJpB7AcUFhvPk8iZ2O1uhS6dhY8BofdcbsY30Yd6nfWbE4URn3XhZZggcZ3wqzlcYw P0jGs3k/2joqfJh2WIoVp/4dv/FgDdKWBV/BlOrGVFbIv5SSjZn0izh6edmqCwIAn5AA PXj/ViKYwiGKscG3teARvIoZxoc4O7u+VkuUXwqlgYbxGT2ha1UhkfJb8AJKylHpc2YP ikTjoCWog8OqtrLGA91SrTPJQyIeZ/pZrbyFjWAWnTQHdAetHhlqPpqUhplWfVYc1gYM yG4w==
X-Gm-Message-State	AFeK/H1YQwCgIG1zvl7oYJOIhEEoEr6QEXctWADU6aAXPKSFMDhUWhBeoEc9mFwyVL6tKNvEdbPQpseVaWaoRw==
X-Received	by 10.55.221.209 with SMTP id u78mr29421793qku.287.1489403441886; Mon, 13 Mar 2017 04:10:41 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Chen-Yu Tsai <wens@csie.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>
X-Original-Date	Mon, 13 Mar 2017 13:10:41 +0200
X-Original-Message-ID	<CAHp75VcCA4+wz4hcqbdRBroxi5pQi8S+s1Ymp55o4sfHC3haWA@mail.gmail.com>
X-Original-References	<20170313084003.14416-1-hdegoede@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1599222

Show key headers only | View raw

On Mon, Mar 13, 2017 at 10:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> With the new more strict ACPI gpio code the dsdt's IoRestriction
> flags are honored on gpiod_get, but in some dsdt's it is wrong,
> so explicitly call gpiod_direction_input on the id gpio if
> necessary.
>
> This fixes the following errors when the int3496 code is used
> together with the new more strict ACPI gpio code:
>
> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22

> +               dev_warn(dev, "firmware bug USB ID GPIO not in input mode, fixing\n");

Please, use FW_BUG macro.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary Hans de Goede <hdegoede@redhat.com> - 2017-03-13 10:30 +0100
  Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 11:40 +0100
    Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Hans de Goede <hdegoede@redhat.com> - 2017-03-13 12:00 +0100
      Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 12:10 +0100
  Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 12:20 +0100

csiph-web