Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary
Date	2017-03-13 12:20 +0100
Message-ID	<tkwb8-8aF-9@gated-at.bofh.it> (permalink)
References	<tkusH-6Sd-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 10:40 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> With the new more strict ACPI gpio code the dsdt's IoRestriction
> flags are honored on gpiod_get, but in some dsdt's it is wrong,
> so explicitly call gpiod_direction_input on the id gpio if
> necessary.
>
> This fixes the following errors when the int3496 code is used
> together with the new more strict ACPI gpio code:
>
> [ 2382.484415] gpio gpiochip1: (INT33FF:01): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
> [ 2382.484425] gpio gpiochip1: (INT33FF:01): unable to lock HW IRQ 3 for IRQ
> [ 2382.484429] genirq: Failed to request resources for INT3496:00 (irq 174) on irqchip chv-gpio
> [ 2382.484518] intel-int3496 INT3496:00: can't request IRQ for USB ID GPIO: -22
> [ 2382.500359] intel-int3496: probe of INT3496:00 failed with error -22

> +               dev_warn(dev, "firmware bug USB ID GPIO not in input mode, fixing\n");

Please, use FW_BUG macro.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary Hans de Goede <hdegoede@redhat.com> - 2017-03-13 10:30 +0100
  Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 11:40 +0100
    Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Hans de Goede <hdegoede@redhat.com> - 2017-03-13 12:00 +0100
      Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if  necessary Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 12:10 +0100
  Re: [PATCH v2] extcon: int3496: Set the id pin to direction-input if necessary Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-03-13 12:20 +0100

csiph-web