Re: net: deadlock between ip_expire/sch_direct_xmit

From	Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: net: deadlock between ip_expire/sch_direct_xmit
Date	2017-03-14 17:50 +0100
Message-ID	<tkXO1-2Py-13@gated-at.bofh.it> (permalink)
References	<tkUQb-Mo-53@gated-at.bofh.it> <tkVVU-1uM-17@gated-at.bofh.it> <tkW5z-1Ad-3@gated-at.bofh.it> <tkW5z-1Ad-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 14, 2017 at 7:56 AM, Eric Dumazet <edumazet@google.com> wrote:
> On Tue, Mar 14, 2017 at 7:46 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
>
>> I am confused. Lockdep has observed both of these stacks:
>>
>>        CPU0                    CPU1
>>        ----                    ----
>>   lock(&(&q->lock)->rlock);
>>                                lock(_xmit_ETHER#2);
>>                                lock(&(&q->lock)->rlock);
>>   lock(_xmit_ETHER#2);
>>
>>
>> So it somehow happened. Or what do you mean?
>>
>
> Lockdep said " possible circular locking dependency detected " .
> It is not an actual deadlock, but lockdep machinery firing.
>
> For a dead lock to happen, this would require that he ICMP message
> sent by ip_expire() is itself fragmented and reassembled.
> This cannot be, because ICMP messages are not candidates for
> fragmentation, but lockdep can not know that of course...

It doesn't have to be ICMP, as long as get the same hash for
the inet_frag_queue, we will need to take the same lock and
deadlock will happen.

        hash = ipqhashfn(iph->id, iph->saddr, iph->daddr, iph->protocol);

So it is really up to this hash function.

Thread

net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 14:40 +0100
  Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-14 15:50 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <edumazet@google.com> - 2017-03-14 16:00 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 16:00 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Cong Wang <xiyou.wangcong@gmail.com> - 2017-03-14 17:50 +0100
        Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-20 11:10 +0100
          Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 13:50 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 16:00 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Paolo Abeni <pabeni@redhat.com> - 2017-03-14 16:10 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <edumazet@google.com> - 2017-03-14 16:20 +0100
        Re: net: deadlock between ip_expire/sch_direct_xmit Paolo Abeni <pabeni@redhat.com> - 2017-03-14 16:40 +0100

csiph-web