Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600581

Re: net: deadlock between ip_expire/sch_direct_xmit

From Eric Dumazet <edumazet@google.com>
Newsgroups linux.kernel
Subject Re: net: deadlock between ip_expire/sch_direct_xmit
Date 2017-03-14 16:20 +0100
Message-ID <tkWoV-1WG-17@gated-at.bofh.it> (permalink)
References <tkUQb-Mo-53@gated-at.bofh.it> <tkVVU-1uM-17@gated-at.bofh.it> <tkWfh-1T2-53@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 14, 2017 at 8:03 AM, Paolo Abeni <pabeni@redhat.com> wrote:

> I'm wondering if we really need to keep the fragment queue lock held
> while sending the icmp packet ? we hold a reference to the struct, so
> it can't be deleted, and AFAICS after ipq_kill() nobody else could
> access/modify that queue.
>
> That lock is there pretty much forever, but perhaps is only a leftover
> and we can release it just after ipq_kill() ?

Maybe, but for peace of mind I would make sure this code path owns the
skb (head) before releasing the lock.

Seems something to try for net-next ?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 14:40 +0100
  Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-14 15:50 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <edumazet@google.com> - 2017-03-14 16:00 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 16:00 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Cong Wang <xiyou.wangcong@gmail.com> - 2017-03-14 17:50 +0100
        Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-20 11:10 +0100
          Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-20 13:50 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Dmitry Vyukov <dvyukov@google.com> - 2017-03-14 16:00 +0100
    Re: net: deadlock between ip_expire/sch_direct_xmit Paolo Abeni <pabeni@redhat.com> - 2017-03-14 16:10 +0100
      Re: net: deadlock between ip_expire/sch_direct_xmit Eric Dumazet <edumazet@google.com> - 2017-03-14 16:20 +0100
        Re: net: deadlock between ip_expire/sch_direct_xmit Paolo Abeni <pabeni@redhat.com> - 2017-03-14 16:40 +0100

csiph-web