Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count()

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count()
Date	2017-03-14 13:30 +0100
Message-ID	<tkTKq-8tD-13@gated-at.bofh.it> (permalink)
References	<tcYQW-6Uz-7@gated-at.bofh.it> <tcYQW-6Uz-5@gated-at.bofh.it> <tkRfA-6BP-27@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Tue, 2017-03-14 at 10:46 +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Since gpiod_count() does not return 0 anymore, we don't need to
> > shadow
> > its error code and would safely propagate to the user.
> > 
> > While here, replace second parameter by NULL in order to prevent
> > side
> > effects on _DSD enabled firmware.
> > 
> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> As I understand it Andy, you're more or less default-maintainer for
> drivers/platform/x86 so I can just merge this patch into the
> GPIO tree with the rest?

Correct!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error  from gpiod_count() Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 10:50 +0100
  Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error  from gpiod_count() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-14 13:30 +0100

csiph-web