[PATCH] drm: virtio: fix eno.cocci warnings

From	kbuild test robot <fengguang.wu@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm: virtio: fix eno.cocci warnings
Date	2017-03-14 13:30 +0100
Message-ID	<tkTKq-8tD-7@gated-at.bofh.it> (permalink)
References	<tkTKq-8tD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

drivers/gpu/drm/virtio/virtgpu_vq.c:100:5-11: ERROR: allocation function on line 99 returns NULL not ERR_PTR on failure

 The various basic memory allocation functions don't return ERR_PTR

Generated by: scripts/coccinelle/null/eno.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 virtgpu_vq.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/virtio/virtgpu_vq.c
+++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
@@ -97,7 +97,7 @@ virtio_gpu_get_vbuf(struct virtio_gpu_de
 	struct virtio_gpu_vbuffer *vbuf;
 
 	vbuf = kmem_cache_alloc(vgdev->vbufs, GFP_KERNEL);
-	if (IS_ERR(vbuf))
+	if (!vbuf)
 		return ERR_CAST(vbuf);
 	memset(vbuf, 0, VBUFFER_SIZE);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: virtio: fix eno.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-03-14 13:30 +0100
  Re: [PATCH] drm: virtio: fix eno.cocci warnings Gerd Hoffmann <kraxel@redhat.com> - 2017-03-14 15:10 +0100

csiph-web