Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1600171 > unrolled thread

Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count()

Started byLinus Walleij <linus.walleij@linaro.org>
First post2017-03-14 10:50 +0100
Last post2017-03-14 13:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error  from gpiod_count() Linus Walleij <linus.walleij@linaro.org> - 2017-03-14 10:50 +0100
    Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error  from gpiod_count() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-14 13:30 +0100

#1600171 — Re: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count()

FromLinus Walleij <linus.walleij@linaro.org>
Date2017-03-14 10:50 +0100
SubjectRe: [PATCH v1 3/4] platform/x86: surface3_button: Propagate error from gpiod_count()
Message-ID<tkRfA-6BP-27@gated-at.bofh.it>
On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Since gpiod_count() does not return 0 anymore, we don't need to shadow
> its error code and would safely propagate to the user.
>
> While here, replace second parameter by NULL in order to prevent side
> effects on _DSD enabled firmware.
>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

As I understand it Andy, you're more or less default-maintainer for
drivers/platform/x86 so I can just merge this patch into the
GPIO tree with the rest?

Yours,
Linus Walleij

[toc] | [next] | [standalone]


#1600287

FromAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Date2017-03-14 13:30 +0100
Message-ID<tkTKq-8tD-13@gated-at.bofh.it>
In reply to#1600171
On Tue, 2017-03-14 at 10:46 +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Since gpiod_count() does not return 0 anymore, we don't need to
> > shadow
> > its error code and would safely propagate to the user.
> > 
> > While here, replace second parameter by NULL in order to prevent
> > side
> > effects on _DSD enabled firmware.
> > 
> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> As I understand it Andy, you're more or less default-maintainer for
> drivers/platform/x86 so I can just merge this patch into the
> GPIO tree with the rest?

Correct!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web