Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1596566

Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge
Date 2017-03-10 03:30 +0100
Message-ID <tjitA-5sB-5@gated-at.bofh.it> (permalink)
References <tjfP3-3Gz-5@gated-at.bofh.it> <tjfP3-3Gz-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 09, 2017 at 06:33:14PM -0500, Vivien Didelot wrote:
> All Marvell switch chips have an ATU accessed using the same Global (1)
> register layout. Only the handling of the FID differs as more bits were
> necessary to support more and more databases.
> 
> Add and use a fresh documented implementation of the ATU Load/Purge.

This is not really the Linux way of doing something. You don't throw
something away and replace it. You incrementally modify what you have
into something better.

I really wished you had moved the code, unmodified, into
global1_atu.c. Then made lots of easy to review small changes. I
cannot just look at this patch and know it is correct. What i need to
compare against is not in this patch. So it is a lot harder to review.

I will continue this review later...

  Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/14] net: dsa: mv88e6xxx: rework ATU support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:30 +0100
      Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-11 22:00 +0100
        Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Andrew Lunn <andrew@lunn.ch> - 2017-03-12 00:50 +0100
          Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-13 16:10 +0100
  [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:20 +0100
  [PATCH net-next 05/14] net: dsa: mv88e6xxx: rework ATU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 06/14] net: dsa: mv88e6xxx: rework ATU Flush Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:10 +0100
    Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:10 +0100
  [PATCH net-next 14/14] etherdevice: remove unused eth_addr_greater Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode  setup Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:30 +0100
  [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:40 +0100
  [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn limit op Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn  limit op Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:40 +0100
  [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority override op Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority  override op Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:40 +0100
  [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port vector member Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port  vector member Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:20 +0100
  [PATCH net-next 11/14] net: dsa: mv88e6xxx: fix port egress flooding mode Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time setter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time  setter Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:50 +0100

csiph-web