Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1596561

Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All

Show all headers | View raw

On Thu, Mar 09, 2017 at 06:33:13PM -0500, Vivien Didelot wrote:
> Marvell switch chips which can be interconnected have an ATU Learn2All
> feature which allows chosen ports to also learn newly added addresses.
> 
> Enable this feature and mark the DSA links as so called "Message Ports".
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c        | 32 +++++++++++++++++++-------------
>  drivers/net/dsa/mv88e6xxx/global1.h     |  1 +
>  drivers/net/dsa/mv88e6xxx/global1_atu.c | 17 +++++++++++++++++
>  drivers/net/dsa/mv88e6xxx/mv88e6xxx.h   |  1 +
>  drivers/net/dsa/mv88e6xxx/port.c        | 18 ++++++++++++++++++
>  drivers/net/dsa/mv88e6xxx/port.h        |  2 ++
>  6 files changed, 58 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 0ad8200f3321..132bda7ca9a8 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -1308,6 +1308,14 @@ static void mv88e6xxx_port_stp_state_set(struct dsa_switch *ds, int port,
>  
>  static int mv88e6xxx_atu_setup(struct mv88e6xxx_chip *chip)
>  {
> +	int err;
> +
> +	if (chip->info->tag_protocol != DSA_TAG_PROTO_TRAILER) {

Hi Vivien

I suspect a lot of things are going to go wrong if this driver is ever
used with that tagging protocol. And it will be even worse with QCA or
BRCM. Yes, at some point, 6060 might get merged, and we will have to
scatter such checks around. But until then, please can we not do this.

      Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/14] net: dsa: mv88e6xxx: rework ATU support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:30 +0100
      Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-11 22:00 +0100
        Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Andrew Lunn <andrew@lunn.ch> - 2017-03-12 00:50 +0100
          Re: [PATCH net-next 04/14] net: dsa: mv88e6xxx: rework ATU Load/Purge Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-13 16:10 +0100
  [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 08/14] net: dsa: mv88e6xxx: rename new FID helper Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:20 +0100
  [PATCH net-next 05/14] net: dsa: mv88e6xxx: rework ATU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 06/14] net: dsa: mv88e6xxx: rework ATU Flush Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:10 +0100
    Re: [PATCH net-next 03/14] net: dsa: mv88e6xxx: setup ATU Learn2All Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:10 +0100
  [PATCH net-next 14/14] etherdevice: remove unused eth_addr_greater Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode setup Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 10/14] net: dsa: mv88e6xxx: rework port mode  setup Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:30 +0100
  [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 07/14] net: dsa: mv88e6xxx: rework ATU Remove Andrew Lunn <andrew@lunn.ch> - 2017-03-10 03:40 +0100
  [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn limit op Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 12/14] net: dsa: mv88e6xxx: add port ATU learn  limit op Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:40 +0100
  [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority override op Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 13/14] net: dsa: mv88e6xxx: add port priority  override op Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:40 +0100
  [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port vector member Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 09/14] net: dsa: mv88e6xxx: rename the port  vector member Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:20 +0100
  [PATCH net-next 11/14] net: dsa: mv88e6xxx: fix port egress flooding mode Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
  [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time setter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-03-10 00:40 +0100
    Re: [PATCH net-next 02/14] net: dsa: mv88e6xxx: move ATU ageing time  setter Andrew Lunn <andrew@lunn.ch> - 2017-03-10 01:50 +0100

csiph-web