Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1596337

[PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.albasani.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From sunil.m@techveda.org
Newsgroups linux.kernel
Subject [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct
Date Thu, 09 Mar 2017 20:00:04 +0100
Message-ID <tjbs8-I0-79@gated-at.bofh.it> (permalink)
References <tiqWd-2hL-15@gated-at.bofh.it> <tjbs6-I0-15@gated-at.bofh.it>
X-Original-To gregkh@linuxfoundation.org, dan.carpenter@oracle.com
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=techveda-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n1GfuzSnDzLdJe0sSQHQjubkSrRJ7joeVuaijvswFzQ=; b=QoqCAaQ7b/SMIJdo1A0BvWXZsFi6LkQJDQMoFdCllJgcP4qYN5ivKY1b8mlmCBOafo FmIa1tOODPIi8KqNmx+ty/lKqQ7Os0NAYABdlLOyE9Ox0sPxx2qcN5zDsmIHRAig7BKu icTBAA+G/xHSb22Ql2o4EhEjMpfhb9Di1BSqPhBVxoGp9SQyYVi3PvYzoiySjWL9q3W9 xzK2sojv/otMEXxOIOoSQ1fxp9/0bXV6NjR1DlD6IDUiMGc5xU3mBNaBOsbnQvViDcei /hFJ1LwLnLkHfrF69CbfkXySIgRWrEoDkq6O0bKqEh2NMod2AvOj92Ig6YtaWD0HP8fa wYEg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n1GfuzSnDzLdJe0sSQHQjubkSrRJ7joeVuaijvswFzQ=; b=EJBSRq5uUTEy5M1OrScg3U1D/sEDWf8SbkXuHoqqDtDVcbDPSNWgsH3xhjiuNynz9d tHCnRUvSRgJJ0DiuFcu0oLVHA1//6cf5vU9RhsYZU/TknIQBoTuS6F0p4YoGXChobpWk PZxsfDzAZktK9QcXLvPIRZK9USYwe3t6MEn8PN7d3dwgEGNUkbtJ2cekwiMmUVY1BgeG ZzDVISvx6bzpgwTThxSUdc37viWkxhJrDBCva8fLEqKo6L8RQrhYsDbquXMWu3lwkvB8 qEjlvqb3LAw5B24ticmkheFoTlnChHjxGg4NTKvjQyfoCjQInmpx+pQ5S0nqciF9UVIP TLgg==
X-Gm-Message-State AMke39l8iU7ipSl+duRivEyjr2ZkXckLIQ44H9B8BZwszUTbmFe1su9HFpfnOOxYGrWaEQ==
X-Received by 10.99.0.65 with SMTP id 62mr15507068pga.114.1489085542947; Thu, 09 Mar 2017 10:52:22 -0800 (PST)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
Organization linux.* mail to news gateway
X-Original-Cc devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, suniel.spartan@gmail.com, Suniel Mahesh <sunil.m@techveda.org>
X-Original-Date Fri, 10 Mar 2017 00:20:48 +0530
X-Original-Message-ID <1489085448-3243-6-git-send-email-sunil.m@techveda.org>
X-Original-References <20170307171229.GE4171@mwanda> <1489085448-3243-1-git-send-email-sunil.m@techveda.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1596337

Show key headers only | View raw


From: Suniel Mahesh <sunil.m@techveda.org>

Prefer vzalloc(sizeof(*priv->pFirmware)...) over
vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Changes for v2:

- new patch addition to the series
- Rebased on top of next-20170306
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index fb711d2..a099bce 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -965,7 +965,7 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
 
 	priv->card_type = PCI;
 
-	priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
+	priv->pFirmware = vzalloc(sizeof(*priv->pFirmware));
 	if (!priv->pFirmware)
 		return -ENOMEM;
 	skb_queue_head_init(&priv->skb_queue);
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: rtl8192e: fix coding style issue, improve error handling Suniel Mahesh <sunil.m@techveda.org> - 2017-03-07 08:20 +0100
  Re: [PATCH] staging: rtl8192e: fix coding style issue, improve error  handling Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:20 +0100
    [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues sunil.m@techveda.org - 2017-03-09 20:00 +0100
      Re: [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 14:50 +0100
    [PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 2/5] staging: rtl8192e: Improve error handling sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 4/5] staging: rtl8192e: Fix unbalanced braces around else statement sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 0/5] staging: rtl8192e: Fix coding style, warnings and checks  sunil.m@techveda.org - 2017-03-09 20:00 +0100
      [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m@techveda.org - 2017-03-09 20:00 +0100

csiph-web