Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1596337

[PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct

From sunil.m@techveda.org
Newsgroups linux.kernel
Subject [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct
Date 2017-03-09 20:00 +0100
Message-ID <tjbs8-I0-79@gated-at.bofh.it> (permalink)
References <tiqWd-2hL-15@gated-at.bofh.it> <tjbs6-I0-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Suniel Mahesh <sunil.m@techveda.org>

Prefer vzalloc(sizeof(*priv->pFirmware)...) over
vzalloc(sizeof(struct rt_firmware)...) as reported by checkpatch.pl

Signed-off-by: Suniel Mahesh <sunil.m@techveda.org>
---
Changes for v2:

- new patch addition to the series
- Rebased on top of next-20170306
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index fb711d2..a099bce 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -965,7 +965,7 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
 
 	priv->card_type = PCI;
 
-	priv->pFirmware = vzalloc(sizeof(struct rt_firmware));
+	priv->pFirmware = vzalloc(sizeof(*priv->pFirmware));
 	if (!priv->pFirmware)
 		return -ENOMEM;
 	skb_queue_head_init(&priv->skb_queue);
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: rtl8192e: fix coding style issue, improve error handling Suniel Mahesh <sunil.m@techveda.org> - 2017-03-07 08:20 +0100
  Re: [PATCH] staging: rtl8192e: fix coding style issue, improve error  handling Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:20 +0100
    [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues sunil.m@techveda.org - 2017-03-09 20:00 +0100
      Re: [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 14:50 +0100
    [PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 2/5] staging: rtl8192e: Improve error handling sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 4/5] staging: rtl8192e: Fix unbalanced braces around else statement sunil.m@techveda.org - 2017-03-09 20:00 +0100
    [PATCH v2 0/5] staging: rtl8192e: Fix coding style, warnings and checks  sunil.m@techveda.org - 2017-03-09 20:00 +0100
      [PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m@techveda.org - 2017-03-09 20:00 +0100

csiph-web