Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1596322
| From | sunil.m@techveda.org |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions |
| Date | 2017-03-09 20:00 +0100 |
| Message-ID | <tjbs7-I0-43@gated-at.bofh.it> (permalink) |
| References | <tiqWd-2hL-15@gated-at.bofh.it> <tjbs6-I0-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Suniel Mahesh <sunil.m@techveda.org> Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh <sunil.m@techveda.org> --- Changes for v2: - Rectify pointer comparisions reported by checkpatch.pl in rtl_core.c - new patch addition to the series - Rebased on top of next-20170306 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 2e6b03f..028755b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -469,7 +469,7 @@ static int _rtl92e_qos_assoc_resp(struct r8192_priv *priv, u32 size = sizeof(struct rtllib_qos_parameters); int set_qos_param = 0; - if ((priv == NULL) || (network == NULL)) + if (!priv || !network) return 0; if (priv->rtllib->state != RTLLIB_LINKED) @@ -782,7 +782,7 @@ static int _rtl92e_sta_down(struct net_device *dev, bool shutdownrf) if (priv->up == 0) return -1; - if (priv->rtllib->rtllib_ips_leave != NULL) + if (priv->rtllib->rtllib_ips_leave) priv->rtllib->rtllib_ips_leave(dev); if (priv->rtllib->state == RTLLIB_LINKED) -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: rtl8192e: fix coding style issue, improve error handling Suniel Mahesh <sunil.m@techveda.org> - 2017-03-07 08:20 +0100
Re: [PATCH] staging: rtl8192e: fix coding style issue, improve error handling Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:20 +0100
[PATCH v2 1/5] staging: rtl8192e: Fix coding style issues sunil.m@techveda.org - 2017-03-09 20:00 +0100
Re: [PATCH v2 1/5] staging: rtl8192e: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 14:50 +0100
[PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions sunil.m@techveda.org - 2017-03-09 20:00 +0100
[PATCH v2 2/5] staging: rtl8192e: Improve error handling sunil.m@techveda.org - 2017-03-09 20:00 +0100
[PATCH v2 4/5] staging: rtl8192e: Fix unbalanced braces around else statement sunil.m@techveda.org - 2017-03-09 20:00 +0100
[PATCH v2 0/5] staging: rtl8192e: Fix coding style, warnings and checks sunil.m@techveda.org - 2017-03-09 20:00 +0100
[PATCH v2 5/5] staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct sunil.m@techveda.org - 2017-03-09 20:00 +0100
csiph-web