Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment
Date	Tue, 07 Mar 2017 20:30:03 +0100
Message-ID	<tisY2-3CB-25@gated-at.bofh.it> (permalink)
References	<tidcC-AA-3@gated-at.bofh.it>
X-Original-To	Andrea Ghittino <aghittino@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
X-Source-IP	userp1040.oracle.com [156.151.31.81]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	aditya.shankar@microchip.com, ganesh.krishna@microchip.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 7 Mar 2017 20:23:04 +0300
X-Original-Message-ID	<20170307172304.GH4171@mwanda>
X-Original-References	<20170306211106.GA9885@myhd3>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1594573

Show key headers only | View raw

On Mon, Mar 06, 2017 at 10:11:21PM +0100, Andrea Ghittino wrote:
> Fixed sparse warnings
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2011:52: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2011:52:    expected unsigned short [unsigned] [assigned] [usertype] ht_ext_params
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2011:52:    got restricted __le16 const [usertype] extended_ht_cap_info
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2012:51: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2012:51:    expected unsigned int [unsigned] [assigned] [usertype] ht_tx_bf_cap
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2012:51:    got restricted __le32 const [usertype] tx_BF_cap_info
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2078:51: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2078:51:    expected unsigned short [unsigned] [assigned] [usertype] ht_capa_info
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2078:51:    got restricted __le16 const [usertype] cap_info
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2083:52: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2083:52:    expected unsigned short [unsigned] [assigned] [usertype] ht_ext_params
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2083:52:    got restricted __le16 const [usertype] extended_ht_cap_info
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2084:51: warning: incorrect type in assignment (different base types)
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2084:51:    expected unsigned int [unsigned] [assigned] [usertype] ht_tx_bf_cap
> drivers/staging/wilc1000//wilc_wfi_cfgoperations.c:2084:51:    got restricted __le32 const [usertype] tx_BF_cap_info
> 
> 
> Signed-off-by: Andrea Ghittino <aghittino@gmail.com>
> ---
> Compile tested only

This commit doesn't tell me if you though about what you are doing at
all.  We get so many commits where people just randomly do random endian
things...  Did you think about this?  Could you resend with a better
commit message?

regards,
dan carpenter

Thread

[PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Andrea Ghittino <aghittino@gmail.com> - 2017-03-07 03:40 +0100
  Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 20:30 +0100
    Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 22:10 +0100

csiph-web