Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type assignment
Date	2017-03-07 22:10 +0100
Message-ID	<tiuwN-4QQ-9@gated-at.bofh.it> (permalink)
References	<tidcC-AA-3@gated-at.bofh.it> <tisY2-3CB-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 07, 2017 at 08:23:04PM +0300, Dan Carpenter wrote:
> This commit doesn't tell me if you though about what you are doing at
> all.  We get so many commits where people just randomly do random endian
> things...  Did you think about this?  Could you resend with a better
> commit message?
> 

The commit message should say what the user visible effects of this
bug fix are going to be.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Andrea Ghittino <aghittino@gmail.com> - 2017-03-07 03:40 +0100
  Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 20:30 +0100
    Re: [PATCH] staging: wilc1000: Fix sparse warnings incorrect type  assignment Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 22:10 +0100

csiph-web