Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work()

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work()
Date	2017-03-07 20:30 +0100
Message-ID	<tisY2-3CB-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <tdJPQ-5LC-21@gated-at.bofh.it> <tdLoC-73y-9@gated-at.bofh.it> <te5GF-4ww-7@gated-at.bofh.it> <ti9sl-6oR-9@gated-at.bofh.it> <timfT-7nz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Tue, Mar 07, 2017 at 12:29:32PM +0100, Harald Geyer wrote:
> On 06.03.2017 23:22, Tejun Heo wrote:
> > I don't think it's a matter of "fixing" the existing
> > mod_delayed_work().  What the new function is implementing wouldn't
> > fit use cases where the timeout should only be shortened (IIRC,
> > writeback code does that).
> > 
> > I'm not against adding new interface to handle it better but I think
> > it makes more sense to add both directions.  How about adding
> > expedite_delayed_work_on() and postpone_delayed_work_on()?
> 
> I think such a function should only be added if there is actually
> code using it. So I'd wait for the survey of existing mod_delayed_work()
> users Mark has promised to actually find some bugs that would be fixed
> by the function before adding it.

I clearly remember writing code to work around that.  Unfortunately, I
can't find it right now. :( Note that these cases may use cancel,
update timeout, requeue sequence rather then mod_delayed_work().  But
yeah, we can add the other direction when we find and can convert the
users.

> The names you are proposing feel less clear to me then mod_fwd/mod_bwd,
> but english is not my native tongue, so my feeling is probably no
> strong evidence ... :)

Forward and backward aren't necessarily time related.  It can be
interpreted as relative position from now too - pulling a work item
forward or pushing it backward.  The orientation isn't explicit in the
name.

Thanks.

-- 
tejun

Thread

Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Tejun Heo <tj@kernel.org> - 2017-03-06 23:40 +0100
  Re: [PATCH 1/2] workqueue: Add new function  mod_fwd_delayed_work() Harald Geyer <harald@ccbib.org> - 2017-03-07 13:20 +0100
    Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Tejun Heo <tj@kernel.org> - 2017-03-07 20:30 +0100
  Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Mark Brown <broonie@kernel.org> - 2017-03-07 13:50 +0100

csiph-web