Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594163

Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work()

Show all headers | View raw

On 06.03.2017 23:22, Tejun Heo wrote:
> I don't think it's a matter of "fixing" the existing
> mod_delayed_work().  What the new function is implementing wouldn't
> fit use cases where the timeout should only be shortened (IIRC,
> writeback code does that).
>
> I'm not against adding new interface to handle it better but I think
> it makes more sense to add both directions.  How about adding
> expedite_delayed_work_on() and postpone_delayed_work_on()?

I think such a function should only be added if there is actually
code using it. So I'd wait for the survey of existing 
mod_delayed_work()
users Mark has promised to actually find some bugs that would be fixed
by the function before adding it.

The names you are proposing feel less clear to me then mod_fwd/mod_bwd,
but english is not my native tongue, so my feeling is probably no
strong evidence ... :)

Otherwise I agree with your comments.

Harald

-- 
If you want to support my work:
see http://friends.ccbib.org/harald/supporting/
or donate via peercoin to P98LRdhit3gZbHDBe7ta5jtXrMJUms4p7w
or CLAM xASPBtezLNqj4cUe8MT5nZjthRSEjrRQXN

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Tejun Heo <tj@kernel.org> - 2017-03-06 23:40 +0100
  Re: [PATCH 1/2] workqueue: Add new function  mod_fwd_delayed_work() Harald Geyer <harald@ccbib.org> - 2017-03-07 13:20 +0100
    Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Tejun Heo <tj@kernel.org> - 2017-03-07 20:30 +0100
  Re: [PATCH 1/2] workqueue: Add new function mod_fwd_delayed_work() Mark Brown <broonie@kernel.org> - 2017-03-07 13:50 +0100

csiph-web