Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1594567

Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue

From Mark Stenglein <mark@stengle.in>
Newsgroups linux.kernel
Subject Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue
Date 2017-03-07 20:30 +0100
Message-ID <tirph-2s0-39@gated-at.bofh.it> (permalink)
References <thQJ3-19o-7@gated-at.bofh.it> <tirfz-2oi-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


All,

Thanks for the feedback. Trying to introduce myself and in retrospect
this seems to be a fairly non-productive way to go about it. Apologies
for any time lost.

Best,
Mark Stenglein

On Tue, Mar 07, 2017 at 08:31:13PM +0300, Dan Carpenter wrote:
> On Sun, Mar 05, 2017 at 09:09:12PM -0500, Mark Stenglein wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Mark Stenglein <mark@stengle.in>
> > ---
> >  drivers/staging/wlan-ng/hfa384x.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c85f12..f19984747b1e 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> >  	enum ctlx_state state;	/* Tracks running state */
> >  
> >  	struct completion done;
> > +
> >  	volatile int reapable;	/* Food for the reaper task */
> 
> No blank line needed.  The original is OK.  (Except for the volatile is
> wrong obviously).
> 
> regards,
> dan carpenter
> 

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding style issue Mark Stenglein <mark@stengle.in> - 2017-03-06 03:40 +0100
  Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding  style issue Greg KH <gregkh@linuxfoundation.org> - 2017-03-06 08:00 +0100
  Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding  style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:40 +0100
    Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding  style issue Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-07 18:50 +0100
    Re: [PATCH] Staging: wlan-ng: hfa384x.h: fixed a newline coding  style issue Mark Stenglein <mark@stengle.in> - 2017-03-07 20:30 +0100

csiph-web