Re: [PATCH] mm: Do not use double negation for testing page flags

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: Do not use double negation for testing page flags
Date	2017-03-07 18:50 +0100
Message-ID	<tirpf-2s0-5@gated-at.bofh.it> (permalink)
References	<tiilZ-4E4-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Mar 07, 2017 at 03:36:37PM +0900, Minchan Kim wrote:
> With the discussion[1], I found it seems there are every PageFlags
> functions return bool at this moment so we don't need double
> negation any more.
> Although it's not a problem to keep it, it makes future users
> confused to use dobule negation for them, too.
> 
> Remove such possibility.
> 
> [1] https://marc.info/?l=linux-kernel&m=148881578820434
> 
> Frankly sepaking, I like every PageFlags return bool instead of int.
> It will make it clear. AFAIR, Chen Gang had tried it but don't know
> why it was not merged at that time.
> 
> http://lkml.kernel.org/r/1469336184-1904-1-git-send-email-chengang@emindsoft.com.cn
> 
> Cc: Vlastimil Vlastimil Babka <vbabka@suse.cz>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Chen Gang <gang.chen.5i5j@gmail.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-07 09:10 +0100
  Re: [PATCH] mm: Do not use double negation for testing page flags Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-07 17:10 +0100
    Re: [PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-08 06:50 +0100
      Re: [PATCH] mm: Do not use double negation for testing page flags Vlastimil Babka <vbabka@suse.cz> - 2017-03-08 10:10 +0100
        Re: [PATCH] mm: Do not use double negation for testing page flags Michal Hocko <mhocko@kernel.org> - 2017-03-08 11:00 +0100
        Re: [PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-09 07:50 +0100
  Re: [PATCH] mm: Do not use double negation for testing page flags Johannes Weiner <hannes@cmpxchg.org> - 2017-03-07 18:50 +0100

csiph-web