Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1594389

Re: [PATCH] mm: Do not use double negation for testing page flags

From Anshuman Khandual <khandual@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [PATCH] mm: Do not use double negation for testing page flags
Date 2017-03-07 17:10 +0100
Message-ID <tipQu-1uF-33@gated-at.bofh.it> (permalink)
References <tiilZ-4E4-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 03/07/2017 12:06 PM, Minchan Kim wrote:
> With the discussion[1], I found it seems there are every PageFlags
> functions return bool at this moment so we don't need double
> negation any more.
> Although it's not a problem to keep it, it makes future users
> confused to use dobule negation for them, too.
> 
> Remove such possibility.

A quick search of '!!Page' in the source tree does not show any other
place having this double negation. So I guess this is all which need
to be fixed.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-07 09:10 +0100
  Re: [PATCH] mm: Do not use double negation for testing page flags Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-03-07 17:10 +0100
    Re: [PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-08 06:50 +0100
      Re: [PATCH] mm: Do not use double negation for testing page flags Vlastimil Babka <vbabka@suse.cz> - 2017-03-08 10:10 +0100
        Re: [PATCH] mm: Do not use double negation for testing page flags Michal Hocko <mhocko@kernel.org> - 2017-03-08 11:00 +0100
        Re: [PATCH] mm: Do not use double negation for testing page flags Minchan Kim <minchan@kernel.org> - 2017-03-09 07:50 +0100
  Re: [PATCH] mm: Do not use double negation for testing page flags Johannes Weiner <hannes@cmpxchg.org> - 2017-03-07 18:50 +0100

csiph-web