Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594069
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events |
| Date | 2017-03-07 11:10 +0100 |
| Message-ID | <tike6-5Vf-25@gated-at.bofh.it> (permalink) |
| References | <tg6oV-7DX-3@gated-at.bofh.it> <tg87o-tP-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 28, 2017 at 10:49:16PM -0800, Andi Kleen wrote:
SNIP
> }
> }
>
> +static void collect_all_aliases(struct perf_evsel *counter,
> + void (*cb)(struct perf_evsel *counter, void *data,
> + bool first),
> + void *data)
> +{
> + struct perf_evsel *alias;
> +
> + alias = list_prepare_entry(counter, &(evsel_list->entries), node);
> + list_for_each_entry_continue (alias, &evsel_list->entries, node) {
> + if (strcmp(perf_evsel__name(alias), perf_evsel__name(counter)) ||
> + alias->scale != counter->scale ||
> + alias->cgrp != counter->cgrp ||
> + strcmp(alias->unit, counter->unit) ||
> + nsec_counter(alias) != nsec_counter(counter))
> + break;
> + alias->merged_stat = true;
> + cb(alias, data, false);
> + }
> +}
> +
> static void collect_data(struct perf_evsel *counter,
> void (*cb)(struct perf_evsel *counter, void *data,
> bool first),
> void *data)
> {
could we place the merged_stat condition in here and have
collect_data return value to process or not the current
counter.. looks like we could get rid of 2 merged_stat
conditions in print_counter_aggr and print_aggr
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
perf: Improve support for uncore JSON event lists Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
[PATCH 05/10] perf, tools: Special case uncore_ prefix Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
[PATCH 06/10] perf, tools: Add a simple expression parser for JSON Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:30 +0100
[PATCH 02/10] perf, tools, stat: Collapse identically named events Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:50 +0100
Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events Jiri Olsa <jolsa@redhat.com> - 2017-03-05 19:00 +0100
Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
[PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen <andi@firstfloor.org> - 2017-03-01 12:30 +0100
Re: [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
Re: perf: Improve support for uncore JSON event lists Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
csiph-web