Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events
Date	2017-03-05 19:00 +0100
Message-ID	<thIBP-3Lv-5@gated-at.bofh.it> (permalink)
References	<tg6oV-7DX-3@gated-at.bofh.it> <tg87o-tP-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 28, 2017 at 10:49:16PM -0800, Andi Kleen wrote:

SNIP

>  
>  struct aggr_data {
> @@ -1208,6 +1231,16 @@ static void aggr_cb(struct perf_evsel *counter, void *data, bool first)
>  		if (first)
>  			ad->nr++;
>  		counts = perf_counts(counter->counts, cpu, 0);
> +		/*
> +		 * When any result is bad, make them all to give
> +		 * consistent output in interval mode.
> +		 */
> +		if (counts->ena == 0 || counts->run == 0 ||
> +		    counter->counts->scaled == -1) {
> +			ad->ena = 0;
> +			ad->run = 0;
> +			break;
> +		}

I think this needs to be in separate patch, showing
the interval output before and after the change..

thanks,
jirka

Thread

perf: Improve support for uncore JSON event lists Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
  [PATCH 05/10] perf, tools: Special case uncore_ prefix Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
  [PATCH 06/10] perf, tools: Add a simple expression parser for JSON Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:30 +0100
  [PATCH 02/10] perf, tools, stat: Collapse identically named events Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:50 +0100
    Re: [PATCH 02/10] perf, tools, stat: Collapse identically named  events Jiri Olsa <jolsa@redhat.com> - 2017-03-05 19:00 +0100
    Re: [PATCH 02/10] perf, tools, stat: Collapse identically named  events Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
  [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen <andi@firstfloor.org> - 2017-03-01 12:30 +0100
    Re: [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
  Re: perf: Improve support for uncore JSON event lists Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100

csiph-web