Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1594064

Re: [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric

Show all headers | View raw

On Tue, Feb 28, 2017 at 10:49:22PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Add generic infrastructure to perf stat to output ratios for "MetricExpr"
> entries in the event lists. Many events are more useful as ratios
> than in raw form, typically some count in relation to total ticks.
> 
> Transfer the MetricExpr information from the alias to the evsel.
> 
> We mark the events that need to be collected for MetricExpr, and also
> link the events using them with a pointer. The code is careful
> to always prefer the right event in the same group to minimize
> multiplexing errors. At the moment only a single relation is supported.
> 
> Then add a rblist to the stat shadow code that remembers stats based
> on the cpu and context.
> 
> Then finally update and retrieve and print these values similarly to the
> existing hardcoded perf metrics. We use the simple expression parser
> added earlier to evaluate the expression.
> 
> Normally we just output the result without further commentary,
> but for --metric-only this would lead to empty columns. So for this
> case use the original event as description.
> 
> So far there is no attempt to automatically add the MetricExpr event,
> if it is missing, however we suggest it to the user.
> 
> $ perf stat -a -I 1000 -e '{unc_p_clockticks,unc_p_freq_max_os_cycles}'
>      1.000228813        800,139,950      unc_p_clockticks
>      1.000228813        789,833,783      unc_p_freq_max_os_cycles  #     98.7
>      2.000654229        800,308,990      unc_p_clockticks
>      2.000654229        396,214,238      unc_p_freq_max_os_cycles  #     49.5
> 
> $ perf stat -a -I 1000 -e '{unc_p_clockticks,unc_p_freq_max_os_cycles}' --metric-only
>      1.000206740     48.0
>      2.000451543     48.1

The comment above suggest I'll see 'original event as description' in this example??

However, could you just make those metric names working in here?
Displaying original event for metric value is misleading.

jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

perf: Improve support for uncore JSON event lists Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
  [PATCH 05/10] perf, tools: Special case uncore_ prefix Andi Kleen <andi@firstfloor.org> - 2017-03-01 08:00 +0100
  [PATCH 06/10] perf, tools: Add a simple expression parser for JSON Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:30 +0100
  [PATCH 02/10] perf, tools, stat: Collapse identically named events Andi Kleen <andi@firstfloor.org> - 2017-03-01 09:50 +0100
    Re: [PATCH 02/10] perf, tools, stat: Collapse identically named  events Jiri Olsa <jolsa@redhat.com> - 2017-03-05 19:00 +0100
    Re: [PATCH 02/10] perf, tools, stat: Collapse identically named  events Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
  [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Andi Kleen <andi@firstfloor.org> - 2017-03-01 12:30 +0100
    Re: [PATCH 08/10] perf, tools, stat: Output JSON MetricExpr metric Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100
  Re: perf: Improve support for uncore JSON event lists Jiri Olsa <jolsa@redhat.com> - 2017-03-07 11:10 +0100

csiph-web