Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595307

Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

Show all headers | View raw

Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>

On Wed, Mar 8, 2017 at 6:52 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:00:41 +0100
>
> Delete an assignment for the local variable "status" in an if branch
> because the desired failure indication is already specified by a constant
> error code at the end.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 05d55d361cfe..af8798fd35b1 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
>                 return ERR_PTR(-ENOMEM);
>
>         mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
> -       if (!mr->pages) {
> -               status = -ENOMEM;
> +       if (!mr->pages)
>                 goto pl_err;
> -       }
>
>         status = ocrdma_get_pbl_info(dev, mr, max_num_sg);
>         if (status)
> --
> 2.12.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in  ocrdma_alloc_mr() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:30 +0100
  Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable  assignment in ocrdma_alloc_mr() Devesh Sharma <devesh.sharma@broadcom.com> - 2017-03-08 16:50 +0100
  Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable  assignment in ocrdma_alloc_mr() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-09 13:00 +0100

csiph-web