Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

From	Yuval Shaia <yuval.shaia@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()
Date	2017-03-09 13:00 +0100
Message-ID	<tj4TD-4Fc-3@gated-at.bofh.it> (permalink)
References	<tiJct-6C3-9@gated-at.bofh.it> <tiJPc-77d-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 08, 2017 at 02:22:21PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:00:41 +0100
> 
> Delete an assignment for the local variable "status" in an if branch
> because the desired failure indication is already specified by a constant
> error code at the end.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 05d55d361cfe..af8798fd35b1 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
>  		return ERR_PTR(-ENOMEM);
>  
>  	mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
> -	if (!mr->pages) {
> -		status = -ENOMEM;
> +	if (!mr->pages)
>  		goto pl_err;
> -	}
>  

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

>  	status = ocrdma_get_pbl_info(dev, mr, max_num_sg);
>  	if (status)
> -- 
> 2.12.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in  ocrdma_alloc_mr() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-03-08 14:30 +0100
  Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable  assignment in ocrdma_alloc_mr() Devesh Sharma <devesh.sharma@broadcom.com> - 2017-03-08 16:50 +0100
  Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable  assignment in ocrdma_alloc_mr() Yuval Shaia <yuval.shaia@oracle.com> - 2017-03-09 13:00 +0100

csiph-web