[GIT PULL][PATCH 0/2] ktest: Fixes for 4.11

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	[GIT PULL][PATCH 0/2] ktest: Fixes for 4.11
Date	2017-03-08 17:00 +0100
Message-ID	<tiMam-bQ-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Linus,

Greg Kroah-Hartman reported to me that the ktest of v4.10 locked up in an
infinite loop while doing the make mrproper. Looking into the cause I noticed
that a recent update to the function run_command (used for running all
shell commands, including "make mrproper") changed the internal loop to
use the function wait_for_input. The wait_for_input uses select to look
at two file descriptors. One is the file descriptor of the command it is
running, the other is STDIN. The STDIN check was not checking the return
status of the sysread call, and was also just writing a lot of data into
syswrite without regard to the size of the data read.

Changing the code to check the return status of sysread, and also to still
process the passed in descriptor data without looping back to the select
fixed Greg's problem.

While looking at this code I also realized that the loop did not honor
the timeout if STDIN always had input (or for some reason return error).
this could prevent wait_for_input to timeout on the file descriptor it
is suppose to be waiting for. That is fixed too.

Please pull the latest ktest-v4.11-rc1 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git
ktest-v4.11-rc1

Tag SHA1: 6692cf546881262ada6b98dc7f0ee374922e669b
Head SHA1: f7c6401ff84ab8ffffc281a29aa0a787f7eb346e


Steven Rostedt (VMware) (2):
      ktest: Fix while loop in wait_for_input
      ktest: Make sure wait_for_input does honor the timeout

----
 tools/testing/ktest/ktest.pl | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[GIT PULL][PATCH 0/2] ktest: Fixes for 4.11 Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 17:00 +0100
  [GIT PULL][PATCH 1/2] ktest: Fix while loop in wait_for_input Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 17:00 +0100
  [GIT PULL][PATCH 2/2] ktest: Make sure wait_for_input does honor the timeout Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 17:00 +0100
  Re: [GIT PULL][PATCH 0/2] ktest: Fixes for 4.11 Steven Rostedt <rostedt@goodmis.org> - 2017-03-08 17:30 +0100

csiph-web