Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)
Date	2017-03-02 19:20 +0100
Message-ID	<tgDux-67m-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <tey5X-7ZJ-3@gated-at.bofh.it> <teKTv-8uG-1@gated-at.bofh.it> <tguUi-8v7-21@gated-at.bofh.it> <tgAdk-3As-3@gated-at.bofh.it> <tgAmZ-3FV-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Pavel,

On Thu, Mar 02, 2017 at 03:58:08PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > Making the sub-device bus configuration a pointer should be in a separate
> > > > patch. It makes sense since the entire configuration is not valid for all
> > > > sub-devices attached to the ISP anymore. I think it originally was a
> > > > separate patch, but they probably have been merged at some point. I can't
> > > > find it right now anyway.
> > > 
> > > Something like this?
> > > 
> > > commit df9141c66678b549fac9d143bd55ed0b242cf36e
> > > Author: Pavel <pavel@ucw.cz>
> > > Date:   Wed Mar 1 13:27:56 2017 +0100
> > > 
> > >     Turn bus in struct isp_async_subdev into pointer; some of our subdevs
> > >     (flash, focus) will not need bus configuration.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > I applied this to the ccp2 branch with an improved patch
> > description.
> 
> Thanks!
> 
> [But the important part is to get subdevices to work on ccp2 based
> branch, and it still fails to work at all if I attempt to enable
> them. I'd like to understand why...]

Did you add the flash / lens to the async list? The patches currently in the
ccp branch do not include that --- it should be in parsing the flash /
lens-focus properties in omap3isp device's node.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Thread

subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 10:10 +0100
  Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 15:50 +0100
    Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 16:00 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 19:20 +0100
        Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-04 00:30 +0100
    Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times) Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-02 19:50 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 22:30 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 22:30 +0100

csiph-web