Re: ftrace_graph_filter not working correctly since v4.10

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: ftrace_graph_filter not working correctly since v4.10
Date	2017-03-02 19:20 +0100
Message-ID	<tgDuy-67m-9@gated-at.bofh.it> (permalink)
References	<tgolP-3FJ-9@gated-at.bofh.it> <tgpBf-4Ck-1@gated-at.bofh.it> <tgq4h-4Qm-3@gated-at.bofh.it> <tgDbb-5KR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Namhyung,

Just an FYI...

-- Steve


On Thu, 2 Mar 2017 12:49:40 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 1 Mar 2017 22:47:30 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Wed, 1 Mar 2017 22:28:43 -0500
> > Steven Rostedt <rostedt@goodmis.org> wrote:  
> > > 
> > > 4.10 is fine. It's what has been merged for 4.11 that's broken. I'm
> > > doing a bisect now to see what broke it. Yes, lots of commits touched
> > > that code recently.    
> > 
> > I found the bad commit. I'll have a patch for you to test tomorrow.
> >   
> 
> Can you test this patch please.
> 
> -- Steve
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 2d554a0..1b33a41 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4403,10 +4403,9 @@ static void __init set_ftrace_early_graph(char *buf, int enable)
>  	char *func;
>  	struct ftrace_hash *hash;
>  
> -	if (enable)
> -		hash = ftrace_graph_hash;
> -	else
> -		hash = ftrace_graph_notrace_hash;
> +	hash = alloc_ftrace_hash(FTRACE_HASH_DEFAULT_BITS);
> +	if (WARN_ON(!hash))
> +		return;
>  
>  	while (buf) {
>  		func = strsep(&buf, ",");
> @@ -4416,6 +4415,11 @@ static void __init set_ftrace_early_graph(char *buf, int enable)
>  			printk(KERN_DEBUG "ftrace: function %s not "
>  					  "traceable\n", func);
>  	}
> +
> +	if (enable)
> +		ftrace_graph_hash = hash;
> +	else
> +		ftrace_graph_notrace_hash = hash;
>  }
>  #endif /* CONFIG_FUNCTION_GRAPH_TRACER */
>

Thread

ftrace_graph_filter not working correctly since v4.10 Todd Brandt <todd.e.brandt@linux.intel.com> - 2017-03-02 03:10 +0100
  Re: ftrace_graph_filter not working correctly since v4.10 Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 04:30 +0100
    Re: ftrace_graph_filter not working correctly since v4.10 Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 05:00 +0100
      Re: ftrace_graph_filter not working correctly since v4.10 Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 19:00 +0100
        Re: ftrace_graph_filter not working correctly since v4.10 Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 19:20 +0100
          Re: ftrace_graph_filter not working correctly since v4.10 Todd Brandt <todd.e.brandt@linux.intel.com> - 2017-03-02 21:30 +0100
            Re: ftrace_graph_filter not working correctly since v4.10 Steven Rostedt <rostedt@goodmis.org> - 2017-03-02 22:00 +0100
          Re: ftrace_graph_filter not working correctly since v4.10 Namhyung Kim <namhyung@kernel.org> - 2017-03-03 02:20 +0100

csiph-web