Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)
Date	2017-03-02 22:30 +0100
Message-ID	<tgGsq-852-35@gated-at.bofh.it> (permalink)
References	<taTVo-7JE-21@gated-at.bofh.it> <tguUi-8v7-21@gated-at.bofh.it> <tgAdk-3As-3@gated-at.bofh.it> <tgDXz-6l8-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> > >  static int isp_fwnode_parse(struct device *dev, struct fwnode_handle
> > >  *fwn,
> > >  
> > >  			    struct isp_async_subdev *isd)
> > >  
> > >  {
> > > 
> > > -	struct isp_bus_cfg *buscfg = &isd->bus;
> > > +	struct isp_bus_cfg *buscfg;
> > > 
> > >  	struct v4l2_fwnode_endpoint vfwn;
> > >  	unsigned int i;
> > >  	int ret;
> > >  	bool csi1 = false;
> > > 
> > > +	buscfg = devm_kzalloc(dev, sizeof(*isd->bus), GFP_KERNEL);
> 
> Given that you recently get rid of devm_kzalloc() in the driver, let's not 
> introduce a new one here.

What is wrong with devm_kzalloc()?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 10:10 +0100
  Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 15:50 +0100
    Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 16:00 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 19:20 +0100
        Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-04 00:30 +0100
    Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times) Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-03-02 19:50 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Sakari Ailus <sakari.ailus@iki.fi> - 2017-03-02 22:30 +0100
      Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2:  device_register_subdev_nodes: allow calling multiple times) Pavel Machek <pavel@ucw.cz> - 2017-03-02 22:30 +0100

csiph-web