Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589890
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface |
| Date | Wed, 01 Mar 2017 01:10:02 +0100 |
| Message-ID | <tg00a-3dN-15@gated-at.bofh.it> (permalink) |
| References | <tfXbY-1nX-13@gated-at.bofh.it> <tfXlE-1rB-29@gated-at.bofh.it> <tfXOG-1BX-13@gated-at.bofh.it> |
| X-Original-To | Guenter Roeck <linux@roeck-us.net> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=y/6jZokqqSi4nv/0N63XvS3pniM9y0xMU40WMS1DZfQ=; b=eLkphvQqY2V5M90KO6hUcAaozotGdCHQvIQPg80a8AoNudbFhiG9DKXagGk8DoCCTA q1SyGWsBdLqHiWLfTDF0wpdsca9lwHVdLshUBI5fwzas9BJkh2zSRedt0usAhR3fmXF9 qNSmpsjdxt5zrYi/bzP71WVnpbyNZXWX75n78RzNffKdmRbjzMUzb4d/PamKgKYrhhe8 ZDpyThEsktJaOTEJo0KOYiRg23cYUrVBqrTSfhZyojZtjxD8xjueDrZhMPfIpDASBqAW dJPgmujg+B0/tU6P1wd6utVpefZVPbOFyCmR9i2RiPcIyYRGhlGyaSYRHbN0koqxS+6B WUCA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=y/6jZokqqSi4nv/0N63XvS3pniM9y0xMU40WMS1DZfQ=; b=jikde6rCTMiXjw9YHExQN0cOMmt6NvzEPmPa6AaRthf2Gi5S/7N/A3JosTsx9bpvay rIkMmK1VOoLU/9ubkN8eedorsod3fEfEfpFrBjZsrhOvJrUMm98EDMfo3tKWbNU/F46R fhAIVvVzt03odBIPySq4H55Xo7zwCURyuecoW3ssX7eXIq3sXJyJx2kt86Vr8u99bq0z rUGFnv5pY3KCFRbhBa1sFmwD4J0FMLkPru4Jl9ip3D2TMUAq4/IVGZWyL/sc0ujli35D MkPWGxU3BfXJdBTSWspnJYsXGfXn3wA/L1qGNbL3AsbrYwDQATipxMwxs6RTV5t7n6Z/ KWow== |
| X-Gm-Message-State | AMke39nncB6EN7oyBNSYMCo1EDof8lApX15WAAjAsqUpAy+4R49g4yZZB3vD18QhOE6CGknAUEl4CJB+iGhc6w== |
| X-Received | by 10.202.228.17 with SMTP id b17mr2429909oih.212.1488318422552; Tue, 28 Feb 2017 13:47:02 -0800 (PST) |
| MIME-Version | 1.0 |
| X-Google-Sender-Auth | qDukCdwcWWqPX0D8VG_cTBSMKpo |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Wim Van Sebroeck <wim@iguana.be>, linux-watchdog@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> |
| X-Original-Date | Tue, 28 Feb 2017 22:47:02 +0100 |
| X-Original-Message-ID | <CAK8P3a3iu-2MAdD+-nRQfeOme--LLSAH1LRkREVGRo78m_ra7Q@mail.gmail.com> |
| X-Original-References | <20170228210123.3404816-1-arnd@arndb.de> <20170228210123.3404816-3-arnd@arndb.de> <20170228214203.GE6651@roeck-us.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1589890 |
Show key headers only | View raw
On Tue, Feb 28, 2017 at 10:42 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Tue, Feb 28, 2017 at 10:01:17PM +0100, Arnd Bergmann wrote:
>> When the db8500 watchdog is enabled without the PRCMU, we get a lot of
>> warnings about duplicate or missing helper functions:
>>
>> In file included from drivers/watchdog/ux500_wdt.c:21:0:
>> include/linux/mfd/dbx500-prcmu.h:422:19: error: redefinition of 'prcmu_abb_read'
>> static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size)
>>
>> This removes the duplicate function definitions and moves the helpers in
>> dbx500-prcmu outside of the #ifdef that hides them.
>>
>
> Is that appropriate ? Maybe we should just disable COMPILE_TEST
> for this driver instead.
Or we could do both. The MFD driver was written to support this in principle,
it just hasn't worked in a long time.
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] watchdog fixes for COMPILE_TEST change Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:10 +0100
[PATCH 8/8] watchdog: kempld: revert to full dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
Re: [PATCH 8/8] watchdog: kempld: revert to full dependency Guenter Roeck <linux@roeck-us.net> - 2017-03-01 02:20 +0100
[PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
Re: [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
[PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 01:10 +0100
Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 01:40 +0100
Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 04:10 +0100
Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 10:50 +0100
[PATCH 6/8] watchdog: sp805: add back AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
Re: [PATCH 6/8] watchdog: sp805: add back AMBA dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
Re: [PATCH 0/8] watchdog fixes for COMPILE_TEST change Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:40 +0100
[PATCH 5/8] watchdog: menf21bmc: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:40 +0100
Re: [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
csiph-web