Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589817

[PATCH 5/8] watchdog: menf21bmc: add I2C dependency

Show all headers | View raw

This driver fails to link when CONFIG_I2C is disabled or a loadable module while
the watchdog is built-in:

drivers/watchdog/built-in.o: In function `menf21bmc_wdt_shutdown':
menf21bmc_wdt.c:(.text+0x9b44): undefined reference to `i2c_smbus_write_word_data'
menf21bmc_wdt.c:(.text+0x9b44): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `i2c_smbus_write_word_data'

This adds a Kconfig dependency for it, to enforce a valid configuration.

Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index de52495ef150..ab0ec389e436 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -142,6 +142,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL
 config MENF21BMC_WATCHDOG
 	tristate "MEN 14F021P00 BMC Watchdog"
 	depends on MFD_MENF21BMC || COMPILE_TEST
+	depends on I2C
 	select WATCHDOG_CORE
 	help
 	  Say Y here to include support for the MEN 14F021P00 BMC Watchdog.
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] watchdog fixes for COMPILE_TEST change Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:10 +0100
  [PATCH 8/8] watchdog: kempld: revert to full dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 8/8] watchdog: kempld: revert to full dependency Guenter Roeck <linux@roeck-us.net> - 2017-03-01 02:20 +0100
  [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
  [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
      Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 01:10 +0100
        Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 01:40 +0100
        Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 04:10 +0100
          Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 10:50 +0100
  [PATCH 6/8] watchdog: sp805: add back AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 6/8] watchdog: sp805: add back AMBA dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
  Re: [PATCH 0/8] watchdog fixes for COMPILE_TEST change Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:40 +0100
  [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:40 +0100
    Re: [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100

csiph-web