Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589960

Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface
Date 2017-03-01 04:10 +0100
Message-ID <tg2Ol-54m-5@gated-at.bofh.it> (permalink)
References <tfXbY-1nX-13@gated-at.bofh.it> <tfXlE-1rB-29@gated-at.bofh.it> <tfXOG-1BX-13@gated-at.bofh.it> <tg00a-3dN-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 28, 2017 at 10:47:02PM +0100, Arnd Bergmann wrote:
> On Tue, Feb 28, 2017 at 10:42 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > On Tue, Feb 28, 2017 at 10:01:17PM +0100, Arnd Bergmann wrote:
> >> When the db8500 watchdog is enabled without the PRCMU, we get a lot of
> >> warnings about duplicate or missing helper functions:
> >>
> >> In file included from drivers/watchdog/ux500_wdt.c:21:0:
> >> include/linux/mfd/dbx500-prcmu.h:422:19: error: redefinition of 'prcmu_abb_read'
> >>  static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size)
> >>
> >> This removes the duplicate function definitions and moves the helpers in
> >> dbx500-prcmu outside of the #ifdef that hides them.
> >>
> >
> > Is that appropriate ? Maybe we should just disable COMPILE_TEST
> > for this driver instead.
> 
> Or we could do both. The MFD driver was written to support this in principle,
> it just hasn't worked in a long time.
> 

Can you send me patches to disable COMPILE_TEST for this driver and for retu ?

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] watchdog fixes for COMPILE_TEST change Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:10 +0100
  [PATCH 8/8] watchdog: kempld: revert to full dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 8/8] watchdog: kempld: revert to full dependency Guenter Roeck <linux@roeck-us.net> - 2017-03-01 02:20 +0100
  [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 4/8] watchdog: geode: restore hard CS5535_MFGPT dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
  [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
      Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 01:10 +0100
        Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 01:40 +0100
        Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Guenter Roeck <linux@roeck-us.net> - 2017-03-01 04:10 +0100
          Re: [PATCH 2/8] mfd: db8500-prcmu: fix stub helper interface Arnd Bergmann <arnd@arndb.de> - 2017-03-01 10:50 +0100
  [PATCH 6/8] watchdog: sp805: add back AMBA dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:20 +0100
    Re: [PATCH 6/8] watchdog: sp805: add back AMBA dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100
  Re: [PATCH 0/8] watchdog fixes for COMPILE_TEST change Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:40 +0100
  [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-28 22:40 +0100
    Re: [PATCH 5/8] watchdog: menf21bmc: add I2C dependency Guenter Roeck <linux@roeck-us.net> - 2017-02-28 22:50 +0100

csiph-web